The sync door hanger notification doesn't have a border when using classic or third-party themes

RESOLVED FIXED in Firefox 11

Status

()

Firefox
Theme
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: Ehsan, Assigned: soapy)

Tracking

Trunk
Firefox 11
x86
Windows XP
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 4 obsolete attachments)

Created attachment 580155 [details]
Screenshot

See the screenshot.
Comment on attachment 580155 [details]
Screenshot

This appears to be a different screenshot.
Created attachment 580194 [details]
Screenshot

Sorry!
Attachment #580155 - Attachment is obsolete: true

Updated

6 years ago
Blocks: 618913
(Assignee)

Comment 3

6 years ago
Created attachment 580627 [details] [diff] [review]
Possible patch

It appears the panel-promo-box has too much negative margins with Windows Classic theme and overlaps the border.
Comment on attachment 580627 [details] [diff] [review]
Possible patch

>+@media all and (-moz-windows-classic) {

This is backwards, you need to use -moz-windows-default-theme. See the panel[type="arrow"] styles in <http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/winstripe/global/popup.css>.
Summary: The sync door hander notification doesn't have a border on Windows XP → The sync door hanger notification doesn't have a border on Windows XP
(Assignee)

Comment 5

5 years ago
Created attachment 580719 [details] [diff] [review]
Possible patch v2
Attachment #580627 - Attachment is obsolete: true
Comment on attachment 580719 [details] [diff] [review]
Possible patch v2

Is this correct for Windows XP? Note that popup.css uses -moz-windows-default-theme not just for WINSTRIPE_AERO.
(Assignee)

Comment 7

5 years ago
This bug also affects Windows Classic on Windows 7 as well as third-party themes. Unless you were referring to the styling of the 'panel-promo-box'? It seems it was styled like Windows 7 style on all themes, even third-party ones. Is that the intended behavior?
I was referring to panel-promo-box on Windows XP Luna, which I suspect attachment 580719 [details] [diff] [review] breaks.
Summary: The sync door hanger notification doesn't have a border on Windows XP → The sync door hanger notification doesn't have a border when using classic or third-party themes
(Assignee)

Comment 9

5 years ago
Created attachment 580736 [details] [diff] [review]
Possible patch v3

Fixed styling on Windows XP Luna.
Attachment #580719 - Attachment is obsolete: true

Updated

5 years ago
Attachment #580736 - Flags: review?(dao)
Comment on attachment 580736 [details] [diff] [review]
Possible patch v3

> .panel-promo-box {
>-  margin: 8px -16px -16px -16px;
>-  padding: 8px 16px;
>-  background-color: #f1f5fb;
>-  color: GrayText;
>+  margin: 8px -10px -10px;
>+  padding: 8px 10px;

This box is now transparent, so the padding plus the negative margin doesn't seem to make sense. How about:

  margin: 16px 0 -2px;

> %ifndef WINSTRIPE_AERO
>   border-bottom-left-radius: 6px;
>   border-bottom-right-radius: 6px;
> %endif

This should move inside the -moz-windows-default-theme block.
Attachment #580736 - Flags: review?(dao)
(Assignee)

Comment 11

5 years ago
Created attachment 582542 [details] [diff] [review]
Possible patch v4

(In reply to Dão Gottwald [:dao] from comment #10)
> Comment on attachment 580736 [details] [diff] [review]
> Possible patch v3
> 
> > .panel-promo-box {
> >-  margin: 8px -16px -16px -16px;
> >-  padding: 8px 16px;
> >-  background-color: #f1f5fb;
> >-  color: GrayText;
> >+  margin: 8px -10px -10px;
> >+  padding: 8px 10px;
> 
> This box is now transparent, so the padding plus the negative margin doesn't
> seem to make sense. How about:
> 
>   margin: 16px 0 -2px;
> 
> > %ifndef WINSTRIPE_AERO
> >   border-bottom-left-radius: 6px;
> >   border-bottom-right-radius: 6px;
> > %endif
> 
> This should move inside the -moz-windows-default-theme block.

Added requested changes.
Attachment #580736 - Attachment is obsolete: true

Updated

5 years ago
Attachment #582542 - Flags: review+

Updated

5 years ago
Assignee: nobody → soapyhamhocks
Keywords: checkin-needed
http://hg.mozilla.org/integration/mozilla-inbound/rev/e75f1076eab0
Keywords: checkin-needed
Target Milestone: --- → Firefox 11
https://hg.mozilla.org/mozilla-central/rev/e75f1076eab0
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.