708797 - The sync door hanger notification doesn't have a border when using classic or third-party themes

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[(no longer active)]

Attachment: Screenshot

See the screenshot.

Comment 1

[Dão Gottwald [:dao]]

Comment on attachment 580155 [details]
Screenshot

This appears to be a different screenshot.

Comment 2

[(no longer active)]

Attachment: Screenshot

Sorry!

Comment 3

[Joshua M [:soapy]]

Attachment: Possible patch

It appears the panel-promo-box has too much negative margins with Windows Classic theme and overlaps the border.

Comment 4

[Dão Gottwald [:dao]]

Comment on attachment 580627 [details] [diff] [review]
Possible patch

>+@media all and (-moz-windows-classic) {

This is backwards, you need to use -moz-windows-default-theme. See the panel[type="arrow"] styles in <http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/winstripe/global/popup.css>.

Comment 5

[Joshua M [:soapy]]

Attachment: Possible patch v2

Comment 6

[Dão Gottwald [:dao]]

Comment on attachment 580719 [details] [diff] [review]
Possible patch v2

Is this correct for Windows XP? Note that popup.css uses -moz-windows-default-theme not just for WINSTRIPE_AERO.

Comment 7

[Joshua M [:soapy]]

This bug also affects Windows Classic on Windows 7 as well as third-party themes. Unless you were referring to the styling of the 'panel-promo-box'? It seems it was styled like Windows 7 style on all themes, even third-party ones. Is that the intended behavior?

Comment 8

[Dão Gottwald [:dao]]

I was referring to panel-promo-box on Windows XP Luna, which I suspect attachment 580719 [details] [diff] [review] breaks.

Comment 9

[Joshua M [:soapy]]

Attachment: Possible patch v3

Fixed styling on Windows XP Luna.

Comment 10

[Dão Gottwald [:dao]]

Comment on attachment 580736 [details] [diff] [review]
Possible patch v3

> .panel-promo-box {
>-  margin: 8px -16px -16px -16px;
>-  padding: 8px 16px;
>-  background-color: #f1f5fb;
>-  color: GrayText;
>+  margin: 8px -10px -10px;
>+  padding: 8px 10px;

This box is now transparent, so the padding plus the negative margin doesn't seem to make sense. How about:

  margin: 16px 0 -2px;

> %ifndef WINSTRIPE_AERO
>   border-bottom-left-radius: 6px;
>   border-bottom-right-radius: 6px;
> %endif

This should move inside the -moz-windows-default-theme block.

Comment 11

[Joshua M [:soapy]]

Attachment: Possible patch v4

(In reply to Dão Gottwald [:dao] from comment #10)
> Comment on attachment 580736 [details] [diff] [review]
> Possible patch v3
> 
> > .panel-promo-box {
> >-  margin: 8px -16px -16px -16px;
> >-  padding: 8px 16px;
> >-  background-color: #f1f5fb;
> >-  color: GrayText;
> >+  margin: 8px -10px -10px;
> >+  padding: 8px 10px;
> 
> This box is now transparent, so the padding plus the negative margin doesn't
> seem to make sense. How about:
> 
>   margin: 16px 0 -2px;
> 
> > %ifndef WINSTRIPE_AERO
> >   border-bottom-left-radius: 6px;
> >   border-bottom-right-radius: 6px;
> > %endif
> 
> This should move inside the -moz-windows-default-theme block.

Added requested changes.

Comment 12

[Dão Gottwald [:dao]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/e75f1076eab0

Comment 13

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/e75f1076eab0