Closed
Bug 715059
Opened 13 years ago
Closed 13 years ago
Make ParseNode non-copyable
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla12
People
(Reporter: Waldo, Assigned: Waldo)
Details
Attachments
(1 file)
|
2.12 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
Having ParseNode non-copyable would have saved me about half a day debugging a couple weeks ago.
Attachment #585645 -
Flags: review?(luke)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 585645 [details] [diff] [review] Patch >+ memcpy(node, &other, sizeof(*node)); How about a PodCopy?
Attachment #585645 -
Flags: review?(luke) → review+
|
Assignee | |
Comment 2•13 years ago
|
||
PodCopy requires an assignment operator. https://hg.mozilla.org/integration/mozilla-inbound/rev/f03e02f51529
Target Milestone: --- → mozilla12
|
|
Assignee | |
Comment 3•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f03e02f51529
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•