Last Comment Bug 715059 - Make ParseNode non-copyable
: Make ParseNode non-copyable
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
-- normal (vote)
: mozilla12
Assigned To: Jeff Walden [:Waldo] (remove +bmo to email)
: Jason Orendorff [:jorendorff]
Depends on:
  Show dependency treegraph
Reported: 2012-01-03 20:30 PST by Jeff Walden [:Waldo] (remove +bmo to email)
Modified: 2012-01-27 14:15 PST (History)
1 user (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Patch (2.12 KB, patch)
2012-01-03 20:30 PST, Jeff Walden [:Waldo] (remove +bmo to email)
luke: review+
Details | Diff | Splinter Review

Description User image Jeff Walden [:Waldo] (remove +bmo to email) 2012-01-03 20:30:23 PST
Created attachment 585645 [details] [diff] [review]

Having ParseNode non-copyable would have saved me about half a day debugging a couple weeks ago.
Comment 1 User image Luke Wagner [:luke] 2012-01-05 22:10:34 PST
Comment on attachment 585645 [details] [diff] [review]

>+        memcpy(node, &other, sizeof(*node));

How about a PodCopy?
Comment 2 User image Jeff Walden [:Waldo] (remove +bmo to email) 2012-01-06 13:26:03 PST
PodCopy requires an assignment operator.
Comment 3 User image Jeff Walden [:Waldo] (remove +bmo to email) 2012-01-27 14:15:50 PST

Note You need to log in before you can comment on or make changes to this bug.