Last Comment Bug 715059 - Make ParseNode non-copyable
: Make ParseNode non-copyable
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla12
Assigned To: Jeff Walden [:Waldo] (remove +bmo to email)
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-01-03 20:30 PST by Jeff Walden [:Waldo] (remove +bmo to email)
Modified: 2012-01-27 14:15 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (2.12 KB, patch)
2012-01-03 20:30 PST, Jeff Walden [:Waldo] (remove +bmo to email)
luke: review+
Details | Diff | Splinter Review

Description Jeff Walden [:Waldo] (remove +bmo to email) 2012-01-03 20:30:23 PST
Created attachment 585645 [details] [diff] [review]
Patch

Having ParseNode non-copyable would have saved me about half a day debugging a couple weeks ago.
Comment 1 Luke Wagner [:luke] 2012-01-05 22:10:34 PST
Comment on attachment 585645 [details] [diff] [review]
Patch

>+        memcpy(node, &other, sizeof(*node));

How about a PodCopy?
Comment 2 Jeff Walden [:Waldo] (remove +bmo to email) 2012-01-06 13:26:03 PST
PodCopy requires an assignment operator.

https://hg.mozilla.org/integration/mozilla-inbound/rev/f03e02f51529
Comment 3 Jeff Walden [:Waldo] (remove +bmo to email) 2012-01-27 14:15:50 PST
https://hg.mozilla.org/mozilla-central/rev/f03e02f51529

Note You need to log in before you can comment on or make changes to this bug.