Make ParseNode non-copyable

RESOLVED FIXED in mozilla12

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Waldo, Assigned: Waldo)

Tracking

unspecified
mozilla12
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 585645 [details] [diff] [review]
Patch

Having ParseNode non-copyable would have saved me about half a day debugging a couple weeks ago.
Attachment #585645 - Flags: review?(luke)

Comment 1

6 years ago
Comment on attachment 585645 [details] [diff] [review]
Patch

>+        memcpy(node, &other, sizeof(*node));

How about a PodCopy?
Attachment #585645 - Flags: review?(luke) → review+
PodCopy requires an assignment operator.

https://hg.mozilla.org/integration/mozilla-inbound/rev/f03e02f51529
Target Milestone: --- → mozilla12
https://hg.mozilla.org/mozilla-central/rev/f03e02f51529
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.