Closed Bug 715059 Opened 8 years ago Closed 8 years ago

Make ParseNode non-copyable

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla12

People

(Reporter: Waldo, Assigned: Waldo)

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
Having ParseNode non-copyable would have saved me about half a day debugging a couple weeks ago.
Attachment #585645 - Flags: review?(luke)
Comment on attachment 585645 [details] [diff] [review]
Patch

>+        memcpy(node, &other, sizeof(*node));

How about a PodCopy?
Attachment #585645 - Flags: review?(luke) → review+
PodCopy requires an assignment operator.

https://hg.mozilla.org/integration/mozilla-inbound/rev/f03e02f51529
Target Milestone: --- → mozilla12
https://hg.mozilla.org/mozilla-central/rev/f03e02f51529
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.