Closed
Bug 719945
Opened 13 years ago
Closed 12 years ago
Register page used by "Submit a demo" does not support Browser ID sign in
Categories
(developer.mozilla.org Graveyard :: Demo Studio / Dev Derby, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
2.3
People
(Reporter: havi, Assigned: groovecoder)
References
()
Details
(Whiteboard: u=user c=demos p=2 2.2.1)
Attachments
(1 file)
689 bytes,
patch
|
craigcook
:
review+
|
Details | Diff | Splinter Review |
1. When you click "submit a demo" from the demos page: https://developer.mozilla.org/en-US/demos/) 2. it takes you to this page: https://developer.mozilla.org/en-US/demos/submit 3. If you pick the red button "log in to account" it takes you to a BrowserID flow. Yay! BUT 4. If you pick the green button "Create an Account" it take you to "Register" - https://developer.mozilla.org/en-US/users/register - which still shows the old sign-in workflow 5. Same thing happens if you click the "MDN Account" link on https://developer.mozilla.org/en-US/demos/submit - you end up on the old "Register" page (https://developer.mozilla.org/en-US/users/register)
Assignee | ||
Updated•13 years ago
|
Whiteboard: u=user c=demos p=
Assignee | ||
Updated•13 years ago
|
Whiteboard: u=user c=demos p= → u=user c=demos p=2
Updated•12 years ago
|
Assignee: nobody → lorchard
Comment 2•12 years ago
|
||
Commits pushed to mdn at https://github.com/mozilla/kuma https://github.com/mozilla/kuma/commit/f89bf720e4ca20c8d0d236e840f98da937f7cbb0 fix bug 719945 - Register page used by "Submit a demo" does not support Browser ID sign in * Remove "create account" button on demo submit non-auth'd when browserid is available. * Link "MDN Account" to login when browserid is available. * Embed browserid login form on registration page for legacy links https://github.com/mozilla/kuma/commit/1c3fb1b2dce142679b6b1de5659b932b6d7a8996 Merge pull request #105 from lmorchard/bug-719945-demo-submit-browserid Fix Bug 719945 demo submit browserid
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment 3•12 years ago
|
||
qa-verified-trunk https://developer-stage9.mozillla.org/en-US/users/login?next=/en-US/demos/submit
Updated•12 years ago
|
Whiteboard: u=user c=demos p=2 → u=user c=demos p=2 2.2.1
Target Milestone: 2.2 → 2.3
Assignee | ||
Comment 4•12 years ago
|
||
Something's messed up with the ?next parameter (again?) so I'm going to fix while I'm fixing the users/login loops.
Assignee: lorchard → lcrouch
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 5•12 years ago
|
||
Attachment #597589 -
Flags: review?(craigcook.bugz)
Assignee | ||
Comment 6•12 years ago
|
||
Craig can you apply this patch to MindTouch skin?
Updated•12 years ago
|
Assignee: lcrouch → craigcook.bugz
Comment 7•12 years ago
|
||
Patch applied in r101814
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•12 years ago
|
Assignee: craigcook.bugz → lcrouch
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Updated•12 years ago
|
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
Comment 9•12 years ago
|
||
qa-verified-stage https://developer-stage9.mozilla.org/en-US/demos/submit was able to login with BrowserID
Comment 10•12 years ago
|
||
verified fixed https://developer.mozilla.org/en-US/demos/submit
Status: RESOLVED → VERIFIED
Comment 11•12 years ago
|
||
Comment on attachment 597589 [details] [diff] [review] Update BrowserID form-handling javascript Bugzilla keeps nagging me about outstanding review requests, sorry for the spam on long-fixed patches.
Attachment #597589 -
Flags: review?(craigcook.bugz) → review+
Updated•12 years ago
|
Version: MDN → unspecified
Updated•12 years ago
|
Component: Demos → Demo Studio / Dev Derby
Updated•4 years ago
|
Product: developer.mozilla.org → developer.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•