If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Register page used by "Submit a demo" does not support Browser ID sign in

VERIFIED FIXED in 2.3

Status

Mozilla Developer Network
Demo Studio / Dev Derby
VERIFIED FIXED
6 years ago
4 years ago

People

(Reporter: havi, Assigned: groovecoder)

Tracking

unspecified
x86
Mac OS X
Dependency tree / graph

Details

(Whiteboard: u=user c=demos p=2 2.2.1, URL)

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
1. When you click "submit a demo" from the demos page: https://developer.mozilla.org/en-US/demos/) 

2. it takes you to this page: https://developer.mozilla.org/en-US/demos/submit

3. If you pick the red button "log in to account" it takes you to a BrowserID flow. Yay! BUT 

4. If you pick the green button "Create an Account" it take you to "Register" - 
https://developer.mozilla.org/en-US/users/register - which still shows the old sign-in workflow

5. Same thing happens if you click the "MDN Account" link on https://developer.mozilla.org/en-US/demos/submit  - you end up on the old "Register" page (https://developer.mozilla.org/en-US/users/register)
(Assignee)

Updated

6 years ago
Whiteboard: u=user c=demos p=
(Assignee)

Updated

6 years ago
Whiteboard: u=user c=demos p= → u=user c=demos p=2
Assignee: nobody → lorchard
https://github.com/mozilla/kuma/pull/105

Comment 2

6 years ago
Commits pushed to mdn at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/f89bf720e4ca20c8d0d236e840f98da937f7cbb0
fix bug 719945 - Register page used by "Submit a demo" does not support Browser ID sign in

* Remove "create account" button on demo submit non-auth'd when
  browserid is available.

* Link "MDN Account" to login when browserid is available.

* Embed browserid login form on registration page for legacy links

https://github.com/mozilla/kuma/commit/1c3fb1b2dce142679b6b1de5659b932b6d7a8996
Merge pull request #105 from lmorchard/bug-719945-demo-submit-browserid

Fix Bug 719945 demo submit browserid

Updated

6 years ago
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
qa-verified-trunk https://developer-stage9.mozillla.org/en-US/users/login?next=/en-US/demos/submit
Blocks: 723625
Whiteboard: u=user c=demos p=2 → u=user c=demos p=2 2.2.1
Target Milestone: 2.2 → 2.3
(Assignee)

Comment 4

6 years ago
Something's messed up with the ?next parameter (again?) so I'm going to fix while I'm fixing the users/login loops.
Assignee: lorchard → lcrouch
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 5

6 years ago
Created attachment 597589 [details] [diff] [review]
Update BrowserID form-handling javascript
Attachment #597589 - Flags: review?(craigcook.bugz)
(Assignee)

Comment 6

6 years ago
Craig can you apply this patch to MindTouch skin?
Assignee: lcrouch → craigcook.bugz
Patch applied in r101814
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago6 years ago
Resolution: --- → FIXED
(Assignee)

Updated

6 years ago
Duplicate of this bug: 728394
(Assignee)

Updated

6 years ago
Blocks: 728394
(Assignee)

Updated

6 years ago
Assignee: craigcook.bugz → lcrouch
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Updated

6 years ago
Blocks: 729542
(Assignee)

Updated

6 years ago
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago6 years ago
Resolution: --- → FIXED
qa-verified-stage https://developer-stage9.mozilla.org/en-US/demos/submit was able  to login with BrowserID
verified fixed https://developer.mozilla.org/en-US/demos/submit
Status: RESOLVED → VERIFIED
Comment on attachment 597589 [details] [diff] [review]
Update BrowserID form-handling javascript

Bugzilla keeps nagging me about outstanding review requests, sorry for the spam on long-fixed patches.
Attachment #597589 - Flags: review?(craigcook.bugz) → review+
Version: MDN → unspecified
Component: Demos → Demo Studio / Dev Derby
Product: Mozilla Developer Network → Mozilla Developer Network
You need to log in before you can comment on or make changes to this bug.