719945 - Register page used by "Submit a demo" does not support Browser ID sign in

Status: VERIFIED FIXED

(developer.mozilla.org Graveyard :: Demo Studio / Dev Derby, defect)

Description

[havi hoffman [:havi]]

1. When you click "submit a demo" from the demos page: https://developer.mozilla.org/en-US/demos/) 

2. it takes you to this page: https://developer.mozilla.org/en-US/demos/submit

3. If you pick the red button "log in to account" it takes you to a BrowserID flow. Yay! BUT 

4. If you pick the green button "Create an Account" it take you to "Register" - 
https://developer.mozilla.org/en-US/users/register - which still shows the old sign-in workflow

5. Same thing happens if you click the "MDN Account" link on https://developer.mozilla.org/en-US/demos/submit  - you end up on the old "Register" page (https://developer.mozilla.org/en-US/users/register)

Comment 1

[Les Orchard [:lorchard]]

https://github.com/mozilla/kuma/pull/105

Comment 2

[[github robot]]

Commits pushed to mdn at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/f89bf720e4ca20c8d0d236e840f98da937f7cbb0
fix bug 719945 - Register page used by "Submit a demo" does not support Browser ID sign in

* Remove "create account" button on demo submit non-auth'd when
  browserid is available.

* Link "MDN Account" to login when browserid is available.

* Embed browserid login form on registration page for legacy links

https://github.com/mozilla/kuma/commit/1c3fb1b2dce142679b6b1de5659b932b6d7a8996
Merge pull request #105 from lmorchard/bug-719945-demo-submit-browserid

Fix Bug 719945 demo submit browserid

Comment 3

[raymond [:retornam] (inactive)]

qa-verified-trunk https://developer-stage9.mozillla.org/en-US/users/login?next=/en-US/demos/submit

Comment 4

[Luke Crouch [:groovecoder]]

Something's messed up with the ?next parameter (again?) so I'm going to fix while I'm fixing the users/login loops.

Comment 5

[Luke Crouch [:groovecoder]]

Attachment: Update BrowserID form-handling javascript

Comment 6

[Luke Crouch [:groovecoder]]

Craig can you apply this patch to MindTouch skin?

Comment 7

[Craig Cook (:craigcook)]

Patch applied in r101814

Comment 9

[raymond [:retornam] (inactive)]

qa-verified-stage https://developer-stage9.mozilla.org/en-US/demos/submit was able  to login with BrowserID

Comment 10

[raymond [:retornam] (inactive)]

verified fixed https://developer.mozilla.org/en-US/demos/submit

Comment 11

[Craig Cook (:craigcook)]

Comment on attachment 597589 [details] [diff] [review]
Update BrowserID form-handling javascript

Bugzilla keeps nagging me about outstanding review requests, sorry for the spam on long-fixed patches.