723197 - Possible compiler bug with MSVC 2010 causes miscompilation of CSSParserImpl::ParseProperty

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

https://connect.microsoft.com/VisualStudio/feedback/details/722282/msvc-2010-appears-to-miscompile-cssparserimpl-parseproperty-during-the-profiling-run-of-a-pgo-build

Comment 2

[Serge Gautherie (:sgautherie)]

Ftr, a |#pragma optimize( "", off )| was added as a workaround in bug 563318 comment 39:
https://hg.mozilla.org/mozilla-central/rev/a54f31fa1efd

Comment 3

[Makoto Kato [:m_kato] (PTO until 5/6)]

no PGO error on our VS2013 builder
https://treeherder.mozilla.org/#/jobs?repo=try&revision=47b6686624b3

Comment 4

[Makoto Kato [:m_kato] (PTO until 5/6)]

try again. no PGO error of original.  (although hitting bug1115490 after building successful)
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a5e91d698177

Comment 5

[Makoto Kato [:m_kato] (PTO until 5/6)]

Attachment: Remove old workaround of VS2010

Comment 6

[Makoto Kato [:m_kato] (PTO until 5/6)]

Comment on attachment 8588523 [details] [diff] [review]
Remove old workaround of VS2010

When using VS2010, it throws ICE (internal compiler error) when building source file.

But using VS2013, no error when building and linking.

Comment 7

[Michael Shal [:mshal]]

Comment on attachment 8588523 [details] [diff] [review]
Remove old workaround of VS2010

Although the change looks fine to me, I think you'll need someone in this module for review.

Also the "command timed out" error may or may not be related. That just means that something in the build is hanging - it's possible this patch is introducing a new thing that times out, though that is probably unlikely.

Comment 8

[Makoto Kato [:m_kato] (PTO until 5/6)]

Comment on attachment 8588523 [details] [diff] [review]
Remove old workaround of VS2010

try server is successful during PGO building on VS2013.

When using VS2010, ICE (internal compile error on building) occurred.

Comment 9

[Makoto Kato [:m_kato] (PTO until 5/6)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/38291788a6f4

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/38291788a6f4