751505 - fix and reenable toolkit/components/ctypes/tests/unit/test_finalizer_shouldaccept.js

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Luke Wagner [:luke]]

A new xpcshell test started failing with cpg (bug 650353).  Given that it is only failing on one platform (OSX 10.5 opt) and in finalization, we are suspicious of the test having some timing or order dependency.  Given that this is a new feature, it seems ok to temporarily disable the test (rather than backing out cpg and a bunch of related patches) and investigate pronto.

Comment 1

[David Teller [:Yoric] - still alive but not very active]

I will look at it.

Comment 2

[David Teller [:Yoric] - still alive but not very active]

Attachment: Better memory cleanup during the test.

Propagating the cleanup introduced for bug 745233.

Comment 3

[David Teller [:Yoric] - still alive but not very active]

Attachment: Better memory cleanup during the test.

Sorry for the confusion, this patch should apply cleanly.

Comment 4

[Ed Morley [:emorley]]

Disabled test on inbound to green the tree up for now:
https://hg.mozilla.org/integration/mozilla-inbound/rev/94913b445e72

Comment 5

[Jason Orendorff [:jorendorff]]

Comment on attachment 620676 [details] [diff] [review]
Better memory cleanup during the test.

Yup. It looks like test_to_int should be fixed up too.

Comment 6

[David Teller [:Yoric] - still alive but not very active]

Attachment: Better memory cleanup during the test.

Added a second clean-up, just in case.

Comment 7

[David Teller [:Yoric] - still alive but not very active]

Attachment: Better memory cleanup during the test.

Same patch, but with a newline.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/720b32b1ef1e

Comment 9

[Ed Morley [:emorley]]

(In reply to Ed Morley [:edmorley] from comment #4)
> Disabled test on inbound to green the tree up for now:
> https://hg.mozilla.org/integration/mozilla-inbound/rev/94913b445e72

https://hg.mozilla.org/mozilla-central/rev/94913b445e72

Comment 10

[Ed Morley [:emorley]]

> Created attachment 620707 [details] [diff] [review]
> Better memory cleanup during the test.

https://hg.mozilla.org/mozilla-central/rev/720b32b1ef1e