Closed
Bug 751641
Opened 12 years ago
Closed 12 years ago
Flash player does not start (all plugins have a Java MIME type added)
Categories
(Core Graveyard :: Plug-ins, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla15
People
(Reporter: alice0775, Assigned: jaas)
References
Details
(Keywords: regression)
Attachments
(2 files)
3.04 KB,
patch
|
jst
:
review+
|
Details | Diff | Splinter Review |
685 bytes,
text/plain
|
Details |
Build Identifier: http://hg.mozilla.org/mozilla-central/rev/807403a04a6a Mozilla/5.0 (Windows NT 6.1; WOW64; rv:15.0) Gecko/15.0 Firefox/15.0a1 ID:20120503030512 Flash player does not start if one of plugins disabled. Delete pluginreg.dat from profile folder helps Reproducible: Always Steps to Reproduce: 1. You should install Flash Plugin and several plugins such as Acrobat Acrobat, SilverLight, Google Earth, Java(TM) Platform SE 6 U32 with clean profile. 2. Start Firefox 3. Open Youtube Flash Video http://www.youtube.com/watch?v=55s3T7VRQSc and Confirm play 4. Open Addon Manager and Disable one of plugins(such as Acrobat Acrobat) 5. Restart Firefox 6. Open Youtube Flash Video http://www.youtube.com/watch?v=55s3T7VRQSc again Actual Results: Flash Player does not start Expected Results: Flash Player should start Regression window(m-c) Works: http://hg.mozilla.org/mozilla-central/rev/a8c16e7b819b Mozilla/5.0 (Windows NT 6.1; WOW64; rv:15.0) Gecko/15.0 Firefox/15.0a1 ID:20120502195801 Fails: http://hg.mozilla.org/mozilla-central/rev/807403a04a6a Mozilla/5.0 (Windows NT 6.1; WOW64; rv:15.0) Gecko/15.0 Firefox/15.0a1 ID:20120503030512 Pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=a8c16e7b819b&tochange=807403a04a6a Regression window(m-i) Works: http://hg.mozilla.org/integration/mozilla-inbound/rev/83ff77ce8d6c Mozilla/5.0 (Windows NT 6.1; WOW64; rv:15.0) Gecko/15.0 Firefox/15.0a1 ID:20120501120141 Fails: http://hg.mozilla.org/integration/mozilla-inbound/rev/c3813fbb1c9a Mozilla/5.0 (Windows NT 6.1; WOW64; rv:15.0) Gecko/15.0 Firefox/15.0a1 ID:20120501134841 Pushlog: http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=83ff77ce8d6c&tochange=c3813fbb1c9a Regressed by: 813fbb1c9a Josh Aas — Bug 748343: Remove support for "java" and "packages" objects from the DOM. r=jst sr=smaug a=ehsan CLOSED TREE Java(TM) Platform SE 6 U32 Version: 6.0.320.5 Java Deployment Toolkit 6.0.320.5 Version: 6.0.320.5 Google Earth Plugin Version: 6.2.0.5788 Shockwave Flash Version: 11.2.202.233 Adobe Acrobat Version: 10.1.3.23 Google Update Version: 1.3.21.111 VLC Web Plugin Version: 2.0.0.0 Silverlight Plug-In Version: 5.0.61118.0 QuickTime Plug-in 7.7.1 Version: 7.7.1.0 Windows Genuine Advantage Version: 1.9.9.1 Microsoft® Windows Media Player Firefox Plugin Version: 1.0.0.8 ATOK Version: 19.0.3.0
Reporter | ||
Comment 1•12 years ago
|
||
Step 4. Open Addon Manager and Disable one of plugins(such as Acrobat Acrobat) Maybe not necessary.
Summary: Flash player does not start if one of plugins disabled. → Flash player does not start
Comment 2•12 years ago
|
||
> + // This used to depend on whether or not we had an npruntime-enabled
> + // Java plugin but we don't care any more, we just assume we do.
> + PR_fprintf(fd, "%d%c%s%c%s%c%s%c%c\n",
> + tag->mMimeTypes.Length(), PLUGIN_REGISTRY_FIELD_DELIMITER,
> + "application/x-java-vm-npruntime",
> + PLUGIN_REGISTRY_FIELD_DELIMITER,
> + "",
> + PLUGIN_REGISTRY_FIELD_DELIMITER,
> + "",
> + PLUGIN_REGISTRY_FIELD_DELIMITER,
> + PLUGIN_REGISTRY_END_OF_LINE_MARKER);
Now this code is executed even if the plugin is not Java. Is it correct?
This fixes part of the problem with my patch re: pluginreg.dat. Still need to verify that this fixes the reporter's problem here.
Comment 4•12 years ago
|
||
> 0|application/x-vnd.google.update3webcontrol.3|||$ > 1|application/x-vnd.google.oneclickctrl.9|||$ > 2|application/x-java-vm-npruntime|||$ The last line was not present before bug 748343. Obviously Google Update is not a Java plug-in.
Comment on attachment 620795 [details] [diff] [review] fix v1.0 Review of attachment 620795 [details] [diff] [review]: ----------------------------------------------------------------- Fixes the problem for me. We don't want to add that Java NPRuntime MIME type to all cached plugin MIME lists (my bad) and we don't need to ignore it in the active MIME list either.
Attachment #620795 -
Flags: review?(jst)
Try server run: https://tbpl.mozilla.org/?tree=Try&rev=6c70e151f6c3
Status: NEW → ASSIGNED
Updated•12 years ago
|
Attachment #620795 -
Flags: review?(jst) → review+
Updated•12 years ago
|
Summary: Flash player does not start → Flash player does not start (all plugins are marked as java plugins)
pushed to mozilla-inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/e53c3fb93f8b
Summary: Flash player does not start (all plugins are marked as java plugins) → Flash player does not start (all plugins have a Java MIME type added)
Comment 8•12 years ago
|
||
Setting mIsJavaPlugin was causing the plugin to run in the browser process.
Updated•12 years ago
|
Severity: normal → major
Though this seems to not affect everyone for my personal profile it's no problem only for a default new profile in my case it turns black and i also have a pluginreg.dat and disabled some plugins in that profile.
Comment 10•12 years ago
|
||
Ah nope i had no plugin disabled in my list now i test wise disabled one and after restart no flash playback possible re enabling also doesn't help anymore the profile is practically damaged now and only deleting pluginreg.dat restores it :(
Assignee | ||
Comment 11•12 years ago
|
||
Yeah, anyone who generates a new pluginreg.dat file while this bug is in the build will have a problem. Deleting your pluginreg.dat file is safe, just do that.
Comment 12•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e53c3fb93f8b
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
Comment 14•12 years ago
|
||
(In reply to Josh Aas (Mozilla Corporation) from comment #11) > Yeah, anyone who generates a new pluginreg.dat file while this bug is in the > build will have a problem. Deleting your pluginreg.dat file is safe, just do > that. Doesn't help me personaly a lot if i do that flash works fine indeed but after restart it fails again so i would have to delete now every time before i start firefox pluginreg.dat in my personal profile :) though i wait for todays nightly to see if this is hopefully not the case anymore :)
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•