762329 - Add an additional check to test_browserElement_{oop,inproc}_LoadEvents

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Justin Lebar (not reading bugmail)]

We seem to be missing a locationchange event when this test is run in process.  The test passes right now, but only because it's lax.

I'll attach a patch which makes the test fail.  We should at least figure out why this difference exists.

Comment 1

[Justin Lebar (not reading bugmail)]

Attachment: Patch, v1

Comment 2

[Justin Lebar (not reading bugmail)]

And this now works properly, at least locally.  Let's push this patch to try.

Comment 3

[Justin Lebar (not reading bugmail)]

https://tbpl.mozilla.org/?tree=Try&rev=54a44a7f91ea

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 630792 [details] [diff] [review]
Patch, v1

Sounds good to me.

Just curious there is 2 waitForAllCallbacks methods in the test file. One check for the 3 booleans while the other check only 2 of them. Was it on purpose?

Comment 5

[Justin Lebar (not reading bugmail)]

> Just curious there is 2 waitForAllCallbacks methods in the test file. One check for the 3 
> booleans while the other check only 2 of them. Was it on purpose?

That might have made sense before this change to the test, but it doesn't make sense anymore.  Thanks for catching that!

Comment 6

[Justin Lebar (not reading bugmail)]

https://hg.mozilla.org/projects/birch/rev/9ea387039369

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9ea387039369