Closed
Bug 762329
Opened 12 years ago
Closed 11 years ago
Add an additional check to test_browserElement_{oop,inproc}_LoadEvents
Categories
(Firefox OS Graveyard :: General, defect)
Firefox OS Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: justin.lebar+bug, Assigned: justin.lebar+bug)
References
Details
Attachments
(1 file)
1.12 KB,
patch
|
vingtetun
:
review+
|
Details | Diff | Splinter Review |
We seem to be missing a locationchange event when this test is run in process. The test passes right now, but only because it's lax. I'll attach a patch which makes the test fail. We should at least figure out why this difference exists.
Assignee | ||
Comment 1•12 years ago
|
||
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → justin.lebar+bug
Assignee | ||
Comment 2•12 years ago
|
||
And this now works properly, at least locally. Let's push this patch to try.
Assignee | ||
Comment 3•12 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=54a44a7f91ea
Assignee | ||
Updated•12 years ago
|
Attachment #630792 -
Attachment description: Patch to make test fail in-process. → Patch, v1
Attachment #630792 -
Flags: review?(21)
Assignee | ||
Updated•12 years ago
|
Summary: test_browserFrame4 (aka browserElement_LoadEvents) behaves differently in- and out-of-process → Add an additional check to test_browserElement_{oop,inproc}_LoadEvents
Comment 4•12 years ago
|
||
Comment on attachment 630792 [details] [diff] [review] Patch, v1 Sounds good to me. Just curious there is 2 waitForAllCallbacks methods in the test file. One check for the 3 booleans while the other check only 2 of them. Was it on purpose?
Attachment #630792 -
Flags: review?(21) → review+
Assignee | ||
Comment 5•12 years ago
|
||
> Just curious there is 2 waitForAllCallbacks methods in the test file. One check for the 3
> booleans while the other check only 2 of them. Was it on purpose?
That might have made sense before this change to the test, but it doesn't make sense anymore. Thanks for catching that!
Assignee | ||
Comment 6•11 years ago
|
||
https://hg.mozilla.org/projects/birch/rev/9ea387039369
Comment 7•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9ea387039369
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•