Add an additional check to test_browserElement_{oop,inproc}_LoadEvents

RESOLVED FIXED

Status

Firefox OS
General
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: Justin Lebar (not reading bugmail), Assigned: Justin Lebar (not reading bugmail))

Tracking

unspecified
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
We seem to be missing a locationchange event when this test is run in process.  The test passes right now, but only because it's lax.

I'll attach a patch which makes the test fail.  We should at least figure out why this difference exists.
(Assignee)

Updated

6 years ago
Depends on: 762049
(Assignee)

Updated

6 years ago
Assignee: nobody → justin.lebar+bug
(Assignee)

Comment 2

5 years ago
And this now works properly, at least locally.  Let's push this patch to try.
(Assignee)

Updated

5 years ago
Attachment #630792 - Attachment description: Patch to make test fail in-process. → Patch, v1
Attachment #630792 - Flags: review?(21)
(Assignee)

Updated

5 years ago
Summary: test_browserFrame4 (aka browserElement_LoadEvents) behaves differently in- and out-of-process → Add an additional check to test_browserElement_{oop,inproc}_LoadEvents
Comment on attachment 630792 [details] [diff] [review]
Patch, v1

Sounds good to me.

Just curious there is 2 waitForAllCallbacks methods in the test file. One check for the 3 booleans while the other check only 2 of them. Was it on purpose?
Attachment #630792 - Flags: review?(21) → review+
(Assignee)

Comment 5

5 years ago
> Just curious there is 2 waitForAllCallbacks methods in the test file. One check for the 3 
> booleans while the other check only 2 of them. Was it on purpose?

That might have made sense before this change to the test, but it doesn't make sense anymore.  Thanks for catching that!
https://hg.mozilla.org/mozilla-central/rev/9ea387039369
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.