Closed
Bug 772285
Opened 12 years ago
Closed 12 years ago
rm JSPD_ARGUMENT/JSPD_VARIABLE
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: luke, Unassigned)
References
Details
Attachments
(1 file)
14.34 KB,
patch
|
sfink
:
review+
Honza
:
feedback+
|
Details | Diff | Splinter Review |
These flags ultimately aren't necessary since I can't find any uses of jsdIProperty.varArgSlot in firebug. Firebug seems to run fine and show locals in the watch pane; is there anything I'm missing Jan?
Attachment #640426 -
Flags: review?(sphink)
Attachment #640426 -
Flags: feedback?(odvarko)
Comment 1•12 years ago
|
||
Comment on attachment 640426 [details] [diff] [review] rm Review of attachment 640426 [details] [diff] [review]: ----------------------------------------------------------------- This patch also removes FLAG_ARGUMENT and FLAG_VARIABLE, neither of which seems to show up in the Firebug source either. ::: js/jsd/idl/jsdIDebuggerService.idl @@ -1250,5 @@ > readonly attribute jsdIValue name; > /** value of this property. */ > readonly attribute jsdIValue value; > - /** slot number if this property is a local variable or parameter. */ > - readonly attribute unsigned long varArgSlot; You need to bump the interface uuid.
Attachment #640426 -
Flags: review?(sphink) → review+
Reporter | ||
Comment 2•12 years ago
|
||
(In reply to Steve Fink [:sfink] from comment #1) Good catch, thanks! https://hg.mozilla.org/integration/mozilla-inbound/rev/b036556db80a
Target Milestone: --- → mozilla16
Comment 3•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b036556db80a
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment 4•12 years ago
|
||
Comment on attachment 640426 [details] [diff] [review] rm (sorry for the delay, just got back from vacation) I don't see any troubles in Firebug caused by this patch. Honza
Attachment #640426 -
Flags: feedback?(odvarko) → feedback+
You need to log in
before you can comment on or make changes to this bug.
Description
•