772285 - rm JSPD_ARGUMENT/JSPD_VARIABLE

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Luke Wagner [:luke]]

Attachment: rm

These flags ultimately aren't necessary since I can't find any uses of jsdIProperty.varArgSlot in firebug.  Firebug seems to run fine and show locals in the watch pane; is there anything I'm missing Jan?

Comment 1

[Steve Fink [:sfink] [:s:]]

Comment on attachment 640426 [details] [diff] [review]
rm

Review of attachment 640426 [details] [diff] [review]:
-----------------------------------------------------------------

This patch also removes FLAG_ARGUMENT and FLAG_VARIABLE, neither of which seems to show up in the Firebug source either.

::: js/jsd/idl/jsdIDebuggerService.idl
@@ -1250,5 @@
>      readonly attribute jsdIValue     name;
>      /** value of this property. */
>      readonly attribute jsdIValue     value;
> -    /** slot number if this property is a local variable or parameter. */
> -    readonly attribute unsigned long varArgSlot;

You need to bump the interface uuid.

Comment 2

[Luke Wagner [:luke]]

(In reply to Steve Fink [:sfink] from comment #1)
Good catch, thanks!

https://hg.mozilla.org/integration/mozilla-inbound/rev/b036556db80a

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b036556db80a

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 640426 [details] [diff] [review]
rm

(sorry for the delay, just got back from vacation)

I don't see any troubles in Firebug caused by this patch.

Honza