774088 - 1Password extension broken in recent Nightlies

Status: RESOLVED FIXED

(Firefox :: Extension Compatibility, defect)

Description

[Paul [:pmac] McLanahan]

Attachment: Screenshot

1Password extension version 3.9.5.b3

The extension dialog has looked like the attached screenshot for the past week or so. I wish I had a better idea when it started.

Comment 1

[Loic]

Do you see some messages in the error console?

Comment 2

[Paul [:pmac] McLanahan]

Ah yes. I see the following:

Timestamp: 7/16/12 9:25:56 AM
Error: An exception occurred.
Traceback (most recent call last):
  File "resource://onepassword-at-agilebits-dot-com/addon-kit/lib/panel.js", line 298, in _onShow
    let textColor = win.getComputedStyle(node).getPropertyValue("color");
[Exception... "Operation is not supported"  code: "9" nsresult: "0x80530009 (NotSupportedError)"  location: "resource://onepassword-at-agilebits-dot-com/api-utils/lib/cuddlefish.js -> resource://onepassword-at-agilebits-dot-com/addon-kit/lib/panel.js Line: 298"]

I also see a bunch of these, though I'm not sure if it's related:

Timestamp: 7/16/12 9:27:58 AM
Error: Exposing chrome JS objects to content without __exposedProps__ is insecure and deprecated. See https://developer.mozilla.org/en/XPConnect_wrappers for more information.
Source File: resource://jid1-e9sm6xfuiknupg-at-jetpack-api-utils-lib/securable-module.js -> resource://jid1-e9sm6xfuiknupg-at-jetpack-api-utils-lib/content/worker.js
Line: 230

Comment 3

[Jorge Villalobos [:jorgev] (he/him)]

Adding Dave from 1Password.

Comment 4

[Dave]

Thanks for looping me in on this Jorge.

Does the Addon SDK support the nightlies? Line 298 of panel.js was last changed by Irakli Gozalishvili on 2011-11-10, so this failing code is not new.

My guess is this requires an updated Addon SDK so it would be great to loop someone in from that team. 

Cheers!

–Dave Teare
AgileBits Founder

Comment 5

[Jorge Villalobos [:jorgev] (he/him)]

Irakli, comments?

Comment 6

[Dave]

Sorry I meant to add this but forgot: The version of 1Password Paul mentioned (3.9.5.b3) is using Addon SDK 1.8.  I'm sure Irakli will want to know that :)

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

This should be fixed in the SDK 1.9 betas due to this pull request landing: https://github.com/mozilla/addon-sdk/pull/471

Comment 8

[Alexandre Poirot [:ochameau]]

Yes, it will be fixed by bug 766917.
Unfortunately, for some unknown reason it wasn't pulled in yesterday's 1.9b2 version.

Dave, you would need to repack to 1.9 (when fix pulled) in order to make it work on Nightly again.

Comment 9

[Alexandre Poirot [:ochameau]]

Actually I was wrong this fix was already part of 1.9b1.
So that you should be able to repack against yesterday's 1.9b2:
https://ftp.mozilla.org/pub/mozilla.org/labs/jetpack/addon-sdk-1.9b2.zip

Comment 10

[Dave]

Thanks for your help everyone.

I upgraded to the SDK 1.9 beta in our latest beta and everything seems to be working fine. You can grab the beta for yourself here:

https://d13itkw33a7sus.cloudfront.net/dist/1P/ext/1Password-3.9.6.b2.xpi

Comment 11

[Paul [:pmac] McLanahan]

Thanks all! I apologize for neglecting to close this for so long. I've got some more problems w/ the addon in Aurora now, but I'll file a new bug for that.