Closed
Bug 779217
Opened 12 years ago
Closed 12 years ago
Intermittent test_outgoing_hangup_held.js: got OK, expected outbound to 5555552368 : unknown | got false, expected true
Categories
(Core :: DOM: Device Interfaces, defect)
Core
DOM: Device Interfaces
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: jgriffin, Assigned: hsinyi)
References
Details
(Keywords: intermittent-failure)
Attachments
(1 file, 1 obsolete file)
2.26 KB,
patch
|
philikon
:
review+
|
Details | Diff | Splinter Review |
The Marionette WebAPI test test_outgoing_hangup_held.js sometimes fails with the error: test_outgoing_hangup_held.js TEST-UNEXPECTED-FAIL | Traceback (most recent call last): File "/data/jenkins/workspace/webapi-marionette-test/testing/marionette/client/marionette/marionette_test.py", line 194, in runTest '%d tests failed:\n%s' % (results['failed'], '\n'.join(fails))) AssertionError: 2 tests failed: TEST-UNEXPECTED-FAIL | got OK, expected outbound to 5555552368 : unknown | got false, expected true TEST-UNEXPECTED-FAIL | got undefined, expected OK | got false, expected true The log shows: START LOG: INFO Verifying initial state. Tue Jul 31 2012 02:36:20 GMT+0000 (GMT) INFO Initial call list: OK Tue Jul 31 2012 02:36:20 GMT+0000 (GMT) INFO Make an outgoing call. Tue Jul 31 2012 02:36:20 GMT+0000 (GMT) INFO Call list is now: OK Tue Jul 31 2012 02:36:20 GMT+0000 (GMT) INFO Answering the outgoing call. Tue Jul 31 2012 02:36:20 GMT+0000 (GMT) INFO Received 'connected' call event. Tue Jul 31 2012 02:36:20 GMT+0000 (GMT) INFO Call list is now: outbound to 5555552368 : active,OK Tue Jul 31 2012 02:36:20 GMT+0000 (GMT) INFO Holding the outgoing call. Tue Jul 31 2012 02:36:20 GMT+0000 (GMT) INFO Received 'holding' call event. Tue Jul 31 2012 02:36:20 GMT+0000 (GMT) INFO Received 'held' call event. Tue Jul 31 2012 02:36:20 GMT+0000 (GMT) INFO Call list is now: outbound to 5555552368 : held,OK Tue Jul 31 2012 02:36:20 GMT+0000 (GMT) INFO Hanging up the outgoing call. Tue Jul 31 2012 02:36:20 GMT+0000 (GMT) INFO Received disconnecting call event. Tue Jul 31 2012 02:36:20 GMT+0000 (GMT) INFO Received 'disconnected' call event. Tue Jul 31 2012 02:36:20 GMT+0000 (GMT) INFO Call list is now: OK Tue Jul 31 2012 02:36:20 GMT+0000 (GMT) END LOG:
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → htsai
Assignee | ||
Comment 1•12 years ago
|
||
Consolidate test_outgoing_hangup_held.js
Attachment #648603 -
Flags: review?(philipp)
Assignee | ||
Comment 2•12 years ago
|
||
(In reply to Jonathan Griffin (:jgriffin) from comment #0) > The Marionette WebAPI test test_outgoing_hangup_held.js sometimes fails with > the error: > > test_outgoing_hangup_held.js > TEST-UNEXPECTED-FAIL | Traceback (most recent call last): > File > "/data/jenkins/workspace/webapi-marionette-test/testing/marionette/client/ > marionette/marionette_test.py", line 194, in runTest > '%d tests failed:\n%s' % (results['failed'], '\n'.join(fails))) > AssertionError: 2 tests failed: > TEST-UNEXPECTED-FAIL | got OK, expected outbound to 5555552368 : unknown | > got false, expected true > TEST-UNEXPECTED-FAIL | got undefined, expected OK | got false, expected true > According to the log, when requesting "gsm list", we only got "OK", instead of "outbound to 5555552368 : unknown". I did not encounter this test failure actually. That means emulator hasn't established the dialling call but we thought the emulator had. So, we need to make sure there *is* a call ready for answer(). That's what attachment 648603 [details] [diff] [review] attempts to do. Thanks!
Assignee | ||
Comment 3•12 years ago
|
||
Updated patch. Please also refer to comment 2 for my explanation. Thanks!
Attachment #648603 -
Attachment is obsolete: true
Attachment #648603 -
Flags: review?(philipp)
Attachment #648608 -
Flags: review?(philipp)
Comment 4•12 years ago
|
||
Comment on attachment 648608 [details] [diff] [review] Patch Review of attachment 648608 [details] [diff] [review]: ----------------------------------------------------------------- We can give this a shot. Worst thing that can happen is that the orange manifests as a timeout because we're stuck in a loop asking for "gsm list".
Attachment #648608 -
Flags: review?(philipp) → review+
Assignee | ||
Comment 5•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/8e260b44e90d
Comment 6•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/8e260b44e90d
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
Updated•12 years ago
|
Keywords: intermittent-failure
Updated•12 years ago
|
Whiteboard: [orange]
You need to log in
before you can comment on or make changes to this bug.
Description
•