82000 - nsCategoryManager::DeleteCategoryEntry() has an unused out param

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Judson Valeski]

_retval is never used and it forces callers to pass *something* in which leads
to un-necessary stack allocations.

Comment 1

[Judson Valeski]

Attachment: diffs to activation callsite

Comment 2

[Judson Valeski]

Attachment: mozilla tree-wide diffs.

Comment 3

[Judson Valeski]

looking for r/sr.

Comment 4

[Chak Nanga]

changes look good to me. r=chak

Comment 5

[vidur (gone)]

I presume you've checked the Commercial tree as well. If so, sr=vidur.

Comment 6

[Judson Valeski]

whoops. I had checked the ns tree (made the following modification to the single
callsite), but forgot to post the patch.

Index: nsActivation.cpp
===================================================================
RCS file: /m/src/ns/profile/src/nsActivation.cpp,v
retrieving revision 1.24
diff -r1.24 nsActivation.cpp
908,910c908,909
<     nsXPIDLCString prevEntry;
<     rv = catman->DeleteCategoryEntry(NS_PROFILE_STARTUP_CATEGORY,
NS_ACTIVATION_CONTRACTID, PR_TRUE,
<                                      getter_Copies(prevEntry));
---
>     rv = catman->DeleteCategoryEntry(NS_PROFILE_STARTUP_CATEGORY,
NS_ACTIVATION_CONTRACTID,
>                                      PR_TRUE);

Comment 7

[Judson Valeski]

vidur has sr'd the above patch.

Comment 8

[tor]

a=tor

Comment 9

[Judson Valeski]

fix is in.