821328 - Calling openUILinkIn from PlacesUIUtils.jsm _openNodeIn fails when where = "save"

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[tabmix.onemen]

1. set browser.altClickSave to true
2. Alt+click (enter) from bookmarks sidebar or library

result after bug 814264 landed:
"openUILink/openLinkIn was called with "where == 'save' but without initiatingDoc.  See bug 814264."

result before bug 814264 landed:
saveURL not defined

Comment 1

[Marco Bonardo [:mak]]

it's likely this code needs to be updated to properly pass the document.

Comment 2

[Marco Bonardo [:mak]]

I'm taking this just to have it on the radar, if you want to make a patch feel free to take it.

Comment 3

[Marco Bonardo [:mak]]

so, this was already not working (since it's trying to use saveURL but the sidebar doesn't have contentAreaUtils) and it is still not working (now throws), likely not worth to track, considered it's also enabled through a non-default pref.

Comment 4

[Marco Bonardo [:mak]]

the original bug about "saveURL not defined" is bug 451658

Comment 5

[Marco Bonardo [:mak]]

Attachment: patch v1.0

and I think this is the proper patch to fix both bugs, just ignore alt. alt+click was intended for content links, not for chrome.

Comment 6

[Marco Bonardo [:mak]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f0b590fbfd9f

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f0b590fbfd9f