Closed
Bug 841628
Opened 11 years ago
Closed 11 years ago
Request constructor should verify that url is valid
Categories
(Add-on SDK Graveyard :: General, defect, P2)
Add-on SDK Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: evold, Assigned: jsantell)
References
Details
Attachments
(1 file)
I saw this as a TODO in the source https://github.com/mozilla/addon-sdk/blob/1afc3d73c6e20dc88e9aba91c6ff499d4fcf69ad/lib/sdk/request.js#L27
Reporter | ||
Updated•11 years ago
|
Blocks: sdk/request
Priority: -- → P2
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → jsantell
Assignee | ||
Comment 1•11 years ago
|
||
We could go as hard or as easy as we'd like, seems like this is a fun problem: http://mathiasbynens.be/demo/url-regex I'd rather a more liberal regex than an overly complex/slow/restrictive one as it'd be worse to not let a valid URL in than to let an invalid one work.
Assignee | ||
Comment 2•11 years ago
|
||
Attachment #731958 -
Flags: review?(evold)
Reporter | ||
Comment 3•11 years ago
|
||
Comment on attachment 731958 [details]
GH Pull Request 911
Thanks!
Attachment #731958 -
Flags: review?(evold) → review+
Comment 4•11 years ago
|
||
Commit pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/04c2a1196d0c047530b8fe508dc52971d5111bc1 Merge pull request #911 from jsantell/request-url-validation-841628 Fixes Bug 841628, Request Constructor Validates URL, r+=@erikvold
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 5•11 years ago
|
||
Oops I forgot that there was an api change here, and Irakli needs to approve that sort of thing. Can you take a look at this when you have a chance please Irakli?
Flags: needinfo?(rFobic)
Assignee | ||
Comment 6•11 years ago
|
||
Got a thumbs up from Irakli, after changing method name to `isValidURI`
Comment 7•10 years ago
|
||
needinfo is no longer relevant, as Jordan said I have replied in pull.
Flags: needinfo?(rFobic)
You need to log in
before you can comment on or make changes to this bug.
Description
•