857088 - Ensure the proper gap between tab-strip and titlebar when using large fonts

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

From MattN's comment 108 in bug 813802:

> ... When the menubar is showing with Extra Large Fonts, there is a lot of
> unnecessary space between the tabs and menubar. I think it's still taking
> the height of the app & caption buttons (titlebar-content) into account but
> now that we don't put tabs under the app/caption buttons that doesn't seem
> right.  I'm wondering if I'm taking a step backwards here since the
> calculation has been discussed many times and I didn't note this before.
> This could move to a follow-up although it seems to hint that there are
> fundamental issues with the calculation.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

When I was working on bug 813802, I was using this image for reference:

http://cl.ly/image/423u0z1O0c3x

It's possible I misunderstood, but I seem to recall shorlander saying that the top of the tab-strip needs to be 4px away from the bottom of either the menubar or the window buttons (just choose the "lowest" one).

Following up with shorlander to confirm.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Reference screenshot

So I talked with shorlander, and this screenshot demonstrates the proper behaviour:

When the window buttons are taller than the menubar, the 4px distance should be between the tabstrip and the buttons.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v1

This puts the 4px gap back between the tabstrip and the window buttons when the window buttons are larger than the menu.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

I just checked with shorlander - the 4px gap is always supposed to be there in restored window mode, regardless of whether or not the menu is showing.

Comment 5

[Matthew N. [:MattN]]

Comment on attachment 740268 [details] [diff] [review]
Patch v1

Review of attachment 740268 [details] [diff] [review]:
-----------------------------------------------------------------

Your recent patches haven't included HG headers btw.

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Landed on UX as https://hg.mozilla.org/projects/ux/rev/1db126465f33

Comment 7

[:Gijs (he/him)]

https://hg.mozilla.org/mozilla-central/rev/1db126465f33