Closed Bug 857088 Opened 8 years ago Closed 7 years ago

Ensure the proper gap between tab-strip and titlebar when using large fonts

Categories

(Firefox :: Theme, defect)

All
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 28

People

(Reporter: mconley, Assigned: mconley)

References

Details

(Whiteboard: [Australis:M3])

Attachments

(2 files)

From MattN's comment 108 in bug 813802:

> ... When the menubar is showing with Extra Large Fonts, there is a lot of
> unnecessary space between the tabs and menubar. I think it's still taking
> the height of the app & caption buttons (titlebar-content) into account but
> now that we don't put tabs under the app/caption buttons that doesn't seem
> right.  I'm wondering if I'm taking a step backwards here since the
> calculation has been discussed many times and I didn't note this before.
> This could move to a follow-up although it seems to hint that there are
> fundamental issues with the calculation.
When I was working on bug 813802, I was using this image for reference:

http://cl.ly/image/423u0z1O0c3x

It's possible I misunderstood, but I seem to recall shorlander saying that the top of the tab-strip needs to be 4px away from the bottom of either the menubar or the window buttons (just choose the "lowest" one).

Following up with shorlander to confirm.
Attached image Reference screenshot
So I talked with shorlander, and this screenshot demonstrates the proper behaviour:

When the window buttons are taller than the menubar, the 4px distance should be between the tabstrip and the buttons.
Whiteboard: [Australis:M3]
Attachment #738528 - Attachment is patch: false
Attachment #738528 - Attachment mime type: text/plain → image/png
Attached patch Patch v1Splinter Review
This puts the 4px gap back between the tabstrip and the window buttons when the window buttons are larger than the menu.
Attachment #740268 - Flags: review?(mnoorenberghe+bmo)
I just checked with shorlander - the 4px gap is always supposed to be there in restored window mode, regardless of whether or not the menu is showing.
Comment on attachment 740268 [details] [diff] [review]
Patch v1

Review of attachment 740268 [details] [diff] [review]:
-----------------------------------------------------------------

Your recent patches haven't included HG headers btw.
Attachment #740268 - Flags: review?(mnoorenberghe+bmo) → review+
Summary: Revisit tabs in titlebar calculation → Ensure the proper gap between tab-strip and titlebar when using large fonts
Landed on UX as https://hg.mozilla.org/projects/ux/rev/1db126465f33
Whiteboard: [Australis:M3] → [Australis:M3][fixed-in-ux]
https://hg.mozilla.org/mozilla-central/rev/1db126465f33
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:M3][fixed-in-ux] → [Australis:M3]
Target Milestone: --- → Firefox 28
You need to log in before you can comment on or make changes to this bug.