861980 - B2G Desktop does not compile on Ubuntu 12.04 due to bluetooth socket type issues

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

/share/code/mozbuild/mozilla-central/dom/bluetooth/BluetoothUnixSocketConnector.cpp: In member function ‘virtual bool mozilla::dom::bluetooth::BluetoothUnixSocketConnector::SetUp(int)’:
/share/code/mozbuild/mozilla-central/dom/bluetooth/BluetoothUnixSocketConnector.cpp:127:50: error: invalid conversion from ‘int*’ to ‘socklen_t* {aka unsigned int*}’ [-fpermissive]
/usr/include/x86_64-linux-gnu/sys/socket.h:190:12: error:   initializing argument 5 of ‘int getsockopt(int, int, int, void*, socklen_t*)’ [-fpermissive]

Came in with bug 823803. Thought we were building desktop on tbpl, but guess not.

Comment 1

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Attachment: Patch 1 (v1) - Change sockopt length to be a socklen_t

Changed type, also removed sizeof because we set the optlen in the getsockopt call right after it.

Comment 2

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Attachment: Patch 1 (v2) - Change sockopt length to be a socklen_t

Oops. Forgot that we needed the initial struct size in getsockopt, so readded sizeof. :)

Comment 3

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Marking tef+ because bug 823803 was uplifted already.

Comment 4

[Eric Chou [:ericchou] [:echou]]

Comment on attachment 737605 [details] [diff] [review]
Patch 1 (v2) - Change sockopt length to be a socklen_t

Review of attachment 737605 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.

Comment 5

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

https://tbpl.mozilla.org/?tree=Try&rev=4d382b913e01

Comment 6

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/14810c6f3dde

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/14810c6f3dde

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/2a03e41195bc
https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/6d338a0f8c95

Comment 9

[Cody Roesch [:croesch]]

Can you please provide steps to verify this fix - as we will blackbox test from the UI?

Comment 10

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

This is tested by the sheer fact that it compiles at all. :)

Comment 11

[Cody Roesch [:croesch]]

Marking as QARegressExclude