891806 - Fix "yield without a value is deprecated, and illegal in ES6" warnings

Status: RESOLVED FIXED

(Firefox :: General, defect)

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Attachment: part 1 - replace 'yield;' with 'yield undefined;' in browser/

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

Attachment: part 2 - replace 'yield;' with 'yield undefined;' in content/

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

Attachment: part 3 - replace 'yield;' with 'yield undefined;' in docshell/

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

Attachment: part 4 - replace 'yield;' with 'yield undefined;' in dom/

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

Looks good on try:

https://tbpl.mozilla.org/?tree=Try&rev=873115cf54fe

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 773219 [details] [diff] [review]
part 2 - replace 'yield;' with 'yield undefined;' in content/

Super ugly, but I guess I need to accept this for now.

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 773221 [details] [diff] [review]
part 4 - replace 'yield;' with 'yield undefined;' in dom/

This has 
-  yield; yield;
+  yield undefined; yield;
few times.
Should be yield undefined; yield undefined;
(Don't know why the test has yield; yield;)

Comment 8

[Tim Taubert [:ttaubert] (inactive)]

(In reply to Olli Pettay [:smaug] from comment #7)
> This has 
> -  yield; yield;
> +  yield undefined; yield;
> few times.
> Should be yield undefined; yield undefined;
> (Don't know why the test has yield; yield;)

Good catch, will correct.

Comment 9

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/integration/fx-team/rev/35c5a0f94b65
https://hg.mozilla.org/integration/fx-team/rev/d134dbb62202
https://hg.mozilla.org/integration/fx-team/rev/3e5ac7b98a73
https://hg.mozilla.org/integration/fx-team/rev/c6ecfbeb6553

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/35c5a0f94b65
https://hg.mozilla.org/mozilla-central/rev/d134dbb62202
https://hg.mozilla.org/mozilla-central/rev/3e5ac7b98a73
https://hg.mozilla.org/mozilla-central/rev/c6ecfbeb6553