Fix "yield without a value is deprecated, and illegal in ES6" warnings

RESOLVED FIXED in Firefox 25

Status

()

Firefox
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: ttaubert, Assigned: ttaubert)

Tracking

unspecified
Firefox 25
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments)

Comment hidden (empty)
(Assignee)

Comment 1

5 years ago
Created attachment 773208 [details] [diff] [review]
part 1 - replace 'yield;' with 'yield undefined;' in browser/
Attachment #773208 - Flags: review?(jaws)
(Assignee)

Comment 2

5 years ago
Created attachment 773219 [details] [diff] [review]
part 2 - replace 'yield;' with 'yield undefined;' in content/
Attachment #773219 - Flags: review?(bugs)
(Assignee)

Comment 3

5 years ago
Created attachment 773220 [details] [diff] [review]
part 3 - replace 'yield;' with 'yield undefined;' in docshell/
Attachment #773220 - Flags: review?(bugs)
(Assignee)

Comment 4

5 years ago
Created attachment 773221 [details] [diff] [review]
part 4 - replace 'yield;' with 'yield undefined;' in dom/
Attachment #773221 - Flags: review?(bugs)
(Assignee)

Updated

5 years ago
Blocks: 885463

Comment 6

5 years ago
Comment on attachment 773219 [details] [diff] [review]
part 2 - replace 'yield;' with 'yield undefined;' in content/

Super ugly, but I guess I need to accept this for now.
Attachment #773219 - Flags: review?(bugs) → review+

Updated

5 years ago
Attachment #773220 - Flags: review?(bugs) → review+

Comment 7

5 years ago
Comment on attachment 773221 [details] [diff] [review]
part 4 - replace 'yield;' with 'yield undefined;' in dom/

This has 
-  yield; yield;
+  yield undefined; yield;
few times.
Should be yield undefined; yield undefined;
(Don't know why the test has yield; yield;)
Attachment #773221 - Flags: review?(bugs) → review+
(Assignee)

Comment 8

5 years ago
(In reply to Olli Pettay [:smaug] from comment #7)
> This has 
> -  yield; yield;
> +  yield undefined; yield;
> few times.
> Should be yield undefined; yield undefined;
> (Don't know why the test has yield; yield;)

Good catch, will correct.
You need to log in before you can comment on or make changes to this bug.