904746 - InstallManifest not overwriting symlinks with copied files

Status: NEW

(Firefox Build System :: General, defect)

Description

[Nick Alexander :nalexander [he/him]]

I am experimenting with using InstallManifest and process_install_manifest for Bug 900522.  I just switched my InstallManifest from add_symlink to add_copy, and observe that process_install_manifest has kept the existing symlinks rather than blowing them away and replacing them with copied files.  That surprises me.

Comment 1

[Gregory Szorc [:gps]]

There are tests for this at https://hg.mozilla.org/mozilla-central/file/9ff2fa888c04/python/mozbuild/mozpack/test/test_files.py#l267. However, those are low-level tests on the file classes, not on the install manifest. Not sure if the tests are bad or if we need tests covering the interaction from an install manifest perspective.