Build action for processing install manifests

RESOLVED FIXED in mozilla25

Status

defect
RESOLVED FIXED
6 years ago
a year ago

People

(Reporter: gps, Assigned: gps)

Tracking

(Blocks 1 bug)

Trunk
mozilla25
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Assignee

Description

6 years ago
Now that we have support for install manifests, it would be nice to hook them up to builds. The first step there is writing a build action that processes install manifests.

Will attach a file shortly...
Assignee

Comment 1

6 years ago
Should be straightforward.
Attachment #782717 - Flags: review?(mh+mozilla)
Assignee

Updated

6 years ago
Assignee: nobody → gps
Comment on attachment 782717 [details] [diff] [review]
Add process_install_manifest build action

Review of attachment 782717 [details] [diff] [review]:
-----------------------------------------------------------------

::: python/mozbuild/mozbuild/action/process_install_manifest.py
@@ +9,5 @@
> +from mozpack.manifests import InstallManifest
> +
> +
> +COMPLETE = 'From {dest}: Kept {existing} existing; Added/updated {updated}; '
> +    'Removed {rm_files} files and {rm_dirs} directories.'

This line is not going to end up in COMPLETE. In fact, python barfs about the indentation already.
Attachment #782717 - Flags: review?(mh+mozilla) → review+
Assignee

Comment 5

6 years ago
No way adding a new file that isn't referenced anywhere caused bustage.

https://hg.mozilla.org/integration/mozilla-inbound/rev/a9e41a4c4ee4
https://hg.mozilla.org/mozilla-central/rev/a9e41a4c4ee4
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25

Updated

a year ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.