Closed
Bug 899241
Opened 10 years ago
Closed 10 years ago
Build action for processing install manifests
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla25
People
(Reporter: gps, Assigned: gps)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
1.86 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
Now that we have support for install manifests, it would be nice to hook them up to builds. The first step there is writing a build action that processes install manifests. Will attach a file shortly...
Assignee | ||
Comment 1•10 years ago
|
||
Should be straightforward.
Attachment #782717 -
Flags: review?(mh+mozilla)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → gps
Comment 2•10 years ago
|
||
Comment on attachment 782717 [details] [diff] [review] Add process_install_manifest build action Review of attachment 782717 [details] [diff] [review]: ----------------------------------------------------------------- ::: python/mozbuild/mozbuild/action/process_install_manifest.py @@ +9,5 @@ > +from mozpack.manifests import InstallManifest > + > + > +COMPLETE = 'From {dest}: Kept {existing} existing; Added/updated {updated}; ' > + 'Removed {rm_files} files and {rm_dirs} directories.' This line is not going to end up in COMPLETE. In fact, python barfs about the indentation already.
Attachment #782717 -
Flags: review?(mh+mozilla) → review+
Assignee | ||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/e7d81c2597f2
Flags: in-testsuite-
Comment 4•10 years ago
|
||
Backed out for OSX bustage. https://hg.mozilla.org/integration/mozilla-inbound/rev/aebee2f3b9b2 https://tbpl.mozilla.org/php/getParsedLog.php?id=25940137&tree=Mozilla-Inbound
Assignee | ||
Comment 5•10 years ago
|
||
No way adding a new file that isn't referenced anywhere caused bustage. https://hg.mozilla.org/integration/mozilla-inbound/rev/a9e41a4c4ee4
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a9e41a4c4ee4
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Updated•5 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•