899241 - Build action for processing install manifests

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Gregory Szorc [:gps]]

Now that we have support for install manifests, it would be nice to hook them up to builds. The first step there is writing a build action that processes install manifests.

Will attach a file shortly...

Comment 1

[Gregory Szorc [:gps]]

Attachment: Add process_install_manifest build action

Should be straightforward.

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 782717 [details] [diff] [review]
Add process_install_manifest build action

Review of attachment 782717 [details] [diff] [review]:
-----------------------------------------------------------------

::: python/mozbuild/mozbuild/action/process_install_manifest.py
@@ +9,5 @@
> +from mozpack.manifests import InstallManifest
> +
> +
> +COMPLETE = 'From {dest}: Kept {existing} existing; Added/updated {updated}; '
> +    'Removed {rm_files} files and {rm_dirs} directories.'

This line is not going to end up in COMPLETE. In fact, python barfs about the indentation already.

Comment 3

[Gregory Szorc [:gps]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e7d81c2597f2

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Backed out for OSX bustage.
https://hg.mozilla.org/integration/mozilla-inbound/rev/aebee2f3b9b2

https://tbpl.mozilla.org/php/getParsedLog.php?id=25940137&tree=Mozilla-Inbound

Comment 5

[Gregory Szorc [:gps]]

No way adding a new file that isn't referenced anywhere caused bustage.

https://hg.mozilla.org/integration/mozilla-inbound/rev/a9e41a4c4ee4

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/a9e41a4c4ee4