Closed Bug 1000001 Opened 10 years ago Closed 10 years ago

Regression: Panel re-ordering non functional

Categories

(Firefox for Android Graveyard :: Awesomescreen, defect)

ARM
Android
defect
Not set
normal

Tracking

(firefox31 affected, fennec31+)

VERIFIED FIXED
Firefox 31
Tracking Status
firefox31 --- affected
fennec 31+ ---

People

(Reporter: aryx, Assigned: lucasr)

References

Details

(Keywords: regression, reproducible)

Attachments

(1 file)

Firefox for Android Nightly 20140422, Android 4.1.2, Nexus S

The customized panel positions (e.g. for the built-in one history, bookmarks and top sites) aren't stored and I never seen them applied.

Steps to reproduce:
1. Open Settings/Preferences > Customization (?) > Homescreen.
2. Long-tap History (should be on top) and release the finger.
3. Choose 'Change order'
4. Select 'Move down'.
Actual and expected result: History moved down in list.
5. Leave the settings.
6. Tap into the location bar.
Actual result: History still on the left.
7. Tap the home button to get to Android's homescreen.
8. Long-tap the home button and wipe the Firefox application into termination.
9. Launch Firefox again.
Actual result:
Still the old panel order.

Initial landing of the feature was in bug 959917.
Last good revision: 35180f110e44
First bad revision: 1417d180a1d8

Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=35180f110e44&tochange=1417d180a1d8

These two stand out:

420663b2faaa	Lucas Rocha — Bug 988355 - Properly handle device rotation in DynamicPanel (r=margaret)
ad81e2993209	Lucas Rocha — Bug 974601 - Avoid saving HomeConfig state if still using default configuration (r=margaret)
Flags: needinfo?(lucasr.at.mozilla)
Flags: in-moztrap?(fennec)
Summary: Customized panel positions not stored/don't persist → Regression: Panel re-ordering non functional
tracking-fennec: --- → ?
Comment on attachment 8411040 [details] [diff] [review]
Mark Editor as changed when moving panels (r=margaret)

We need to mark Editor as changed after moving a panel.
Attachment #8411040 - Flags: review?(margaret.leibovic)
Flags: needinfo?(lucasr.at.mozilla)
Assignee: nobody → lucasr.at.mozilla
Comment on attachment 8411040 [details] [diff] [review]
Mark Editor as changed when moving panels (r=margaret)

Review of attachment 8411040 [details] [diff] [review]:
-----------------------------------------------------------------

Oops, good catch.
Attachment #8411040 - Flags: review?(margaret.leibovic) → review+
tracking-fennec: ? → 31+
https://hg.mozilla.org/mozilla-central/rev/b9660304f8ef
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 31
Blocks: 974601
This is now working correctly. 
Firefox 31.0b4, 32.0a2, 33.0a1
Device: Alcatel One Touch 
Android 4.1.2
Status: RESOLVED → VERIFIED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.