1000001 - Regression: Panel re-ordering non functional

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Firefox for Android Nightly 20140422, Android 4.1.2, Nexus S

The customized panel positions (e.g. for the built-in one history, bookmarks and top sites) aren't stored and I never seen them applied.

Steps to reproduce:
1. Open Settings/Preferences > Customization (?) > Homescreen.
2. Long-tap History (should be on top) and release the finger.
3. Choose 'Change order'
4. Select 'Move down'.
Actual and expected result: History moved down in list.
5. Leave the settings.
6. Tap into the location bar.
Actual result: History still on the left.
7. Tap the home button to get to Android's homescreen.
8. Long-tap the home button and wipe the Firefox application into termination.
9. Launch Firefox again.
Actual result:
Still the old panel order.

Initial landing of the feature was in bug 959917.

Comment 1

[Aaron Train [:aaronmt]]

Last good revision: 35180f110e44
First bad revision: 1417d180a1d8

Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=35180f110e44&tochange=1417d180a1d8

These two stand out:

420663b2faaa	Lucas Rocha — Bug 988355 - Properly handle device rotation in DynamicPanel (r=margaret)
ad81e2993209	Lucas Rocha — Bug 974601 - Avoid saving HomeConfig state if still using default configuration (r=margaret)

Comment 2

[Lucas Rocha (:lucasr)]

Attachment: Mark Editor as changed when moving panels (r=margaret)

Comment 3

[Lucas Rocha (:lucasr)]

Comment on attachment 8411040 [details] [diff] [review]
Mark Editor as changed when moving panels (r=margaret)

We need to mark Editor as changed after moving a panel.

Comment 4

[:Margaret Leibovic]

Comment on attachment 8411040 [details] [diff] [review]
Mark Editor as changed when moving panels (r=margaret)

Review of attachment 8411040 [details] [diff] [review]:
-----------------------------------------------------------------

Oops, good catch.

Comment 5

[Lucas Rocha (:lucasr)]

https://hg.mozilla.org/integration/fx-team/rev/b9660304f8ef

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b9660304f8ef

Comment 7

[Ioana Chiorean]

This is now working correctly. 
Firefox 31.0b4, 32.0a2, 33.0a1
Device: Alcatel One Touch 
Android 4.1.2

Comment 8

[Ioana Chiorean]

TC added:
New suite: https://moztrap.mozilla.org/manage/cases/?filter-suite=703
https://moztrap.mozilla.org/manage/case/13911
https://moztrap.mozilla.org/manage/case/13910