Closed Bug 1000051 Opened 6 years ago Closed 6 years ago
DPI] .close-icon width not set, making Add-on SDK toolbar close icons huge
We currently just set width: for the consumers, like the tab and sidebar close buttons, but I think we should just set it in the 2ddpi media query block inside the toolkit theme.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Comment on attachment 8421057 [details] [diff] [review] fix hidpi close icon size, [Approval Request Comment] Bug caused by (feature/regressing bug #): close-icon consolidation and/or SDK sidebars/toolbars User impact if declined: sidebars and SDK toolbars have huge close icons Testing completed (on m-c, etc.): on m-c, local Risk to taking this patch (and alternatives if risky): low, CSS-only String or IDL/UUID changes made by this patch: none
Juan, I know you've verified other Retina specific bugs before... do you think you or someone on your side could also verify this? On Windows (normal and HiDPI) I've seen some other UI issues related to this add-on, but none related to the Close button.
I checked this on a MB with Retina display as well as a Surface Pro 2, using latest 30, 31, 32. Sidebar buttons do not look huge.
Marking verified per comment #9.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.