1000051 - [OSX HiDPI] .close-icon width not set, making Add-on SDK toolbar close icons huge

Status: VERIFIED FIXED

(Toolkit :: Themes, defect)

Description

[:Gijs (he/him)]

Attachment: Screenshot

We currently just set width: for the consumers, like the tab and sidebar close buttons, but I think we should just set it in the 2ddpi media query block inside the toolkit theme.

Comment 1

[:Gijs (he/him)]

Attachment: fix hidpi close icon size,

This also fixes bug 1008594.

Comment 2

[:Gijs (he/him)]

remote:   https://hg.mozilla.org/integration/fx-team/rev/16276ce2ff1a

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/16276ce2ff1a

Comment 4

[:Gijs (he/him)]

Comment on attachment 8421057 [details] [diff] [review]
fix hidpi close icon size,

[Approval Request Comment]
Bug caused by (feature/regressing bug #): close-icon consolidation and/or SDK sidebars/toolbars
User impact if declined: sidebars and SDK toolbars have huge close icons
Testing completed (on m-c, etc.): on m-c, local
Risk to taking this patch (and alternatives if risky): low, CSS-only
String or IDL/UUID changes made by this patch: none

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/7fef39b96efd
https://hg.mozilla.org/releases/mozilla-beta/rev/504c3281b663

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/504c3281b663

Comment 8

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

Juan, I know you've verified other Retina specific bugs before... do you think you or someone on your side could also verify this?

On Windows (normal and HiDPI) I've seen some other UI issues related to this add-on, but none related to the Close button.

Comment 9

[juan becerra [:juanb]]

I checked this on a MB with Retina display as well as a Surface Pro 2, using latest 30, 31, 32. Sidebar buttons do not look huge.

Comment 10

[:Gijs (he/him)]

Marking verified per comment #9.