Closed Bug 1000051 Opened 10 years ago Closed 10 years ago

[OSX HiDPI] .close-icon width not set, making Add-on SDK toolbar close icons huge

Categories

(Toolkit :: Themes, defect)

Product:
Toolkit
Component:
Themes
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla32
Tracking Flags:
Tracking Status
firefox30 --- verified
firefox31 --- verified
firefox32 --- verified

People

(Reporter: Gijs, Assigned: Gijs)

References

Details

(Whiteboard: [qa+] )

Attachments

(2 files)

Screenshot
176.37 KB, image/png
Details
fix hidpi close icon size,
2.64 KB, patch
dao
: review+
lsblakk
: approval-mozilla-aurora+
lsblakk
: approval-mozilla-beta+
Details | Diff | Splinter Review
Attached image Screenshot — 
We currently just set width: for the consumers, like the tab and sidebar close buttons, but I think we should just set it in the 2ddpi media query block inside the toolkit theme.
status-firefox30: --- → affected
status-firefox31: --- → affected
Summary: .close-icon width not set, making Add-on SDK toolbar close icons huge → [OSX HiDPI] .close-icon width not set, making Add-on SDK toolbar close icons huge
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
status-firefox32: --- → affected
See Also: → 1008594
This also fixes bug 1008594.
Attachment #8421057 - Flags: review?(dao)
Blocks: 1008594
Attachment #8421057 - Flags: review?(dao) → review+
remote:   https://hg.mozilla.org/integration/fx-team/rev/16276ce2ff1a
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/16276ce2ff1a
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla32
status-firefox32: affected → fixed
Comment on attachment 8421057 [details] [diff] [review]
fix hidpi close icon size,

[Approval Request Comment]
Bug caused by (feature/regressing bug #): close-icon consolidation and/or SDK sidebars/toolbars
User impact if declined: sidebars and SDK toolbars have huge close icons
Testing completed (on m-c, etc.): on m-c, local
Risk to taking this patch (and alternatives if risky): low, CSS-only
String or IDL/UUID changes made by this patch: none
Attachment #8421057 - Flags: approval-mozilla-beta?
Attachment #8421057 - Flags: approval-mozilla-aurora?
Attachment #8421057 - Flags: approval-mozilla-beta?
Attachment #8421057 - Flags: approval-mozilla-beta+
Attachment #8421057 - Flags: approval-mozilla-aurora?
Attachment #8421057 - Flags: approval-mozilla-aurora+
Whiteboard: [qa+]
No longer blocks: 1008594
See Also: 1008594 → 
Juan, I know you've verified other Retina specific bugs before... do you think you or someone on your side could also verify this?

On Windows (normal and HiDPI) I've seen some other UI issues related to this add-on, but none related to the Close button.
Flags: needinfo?(jbecerra)
I checked this on a MB with Retina display as well as a Surface Pro 2, using latest 30, 31, 32. Sidebar buttons do not look huge.
status-firefox30: fixed → verified
status-firefox31: fixed → verified
status-firefox32: fixed → verified
Flags: needinfo?(jbecerra)
Marking verified per comment #9.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: