Closed Bug 1000251 Opened 8 years ago Closed 1 year ago

Add robocop tests for zooming and zoom session history

Categories

(Firefox for Android Graveyard :: Toolbar, defect)

All
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INCOMPLETE

People

(Reporter: esawin, Assigned: esawin)

References

Details

Attachments

(1 file, 2 obsolete files)

We should have robocop tests for the zoom session history to verify correctness and catch regressions.
Attached patch (WIP) Zoom session history test (obsolete) — Splinter Review
Here is the basic idea for the test.
Attachment #8411069 - Flags: feedback?(snorp)
Attached patch (WIP) Zoom session history test (obsolete) — Splinter Review
Tests skip on Android API levels 8-10, since we depend on |Solo.pinchToZoom|, which is level 14 and up.
Attachment #8411069 - Attachment is obsolete: true
Attachment #8411069 - Flags: feedback?(snorp)
Attachment #8411072 - Flags: feedback?(snorp)
Attachment #8411072 - Flags: feedback?(bugmail.mozilla)
Comment on attachment 8411072 [details] [diff] [review]
(WIP) Zoom session history test

Review of attachment 8411072 [details] [diff] [review]:
-----------------------------------------------------------------

Seems pretty reasonable. I'd suggest using different zoom amounts on the two pages in history just to ensure they get restored properly when going back/forward. Also you can probably add something to MotionEventHelper to simulate pinch zooming and thereby enable the test even on android 8+.
Attachment #8411072 - Flags: feedback?(bugmail.mozilla) → feedback+
Comment on attachment 8411072 [details] [diff] [review]
(WIP) Zoom session history test

Review of attachment 8411072 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. I agree with everything kats said.
Attachment #8411072 - Flags: feedback?(snorp) → feedback+
Reduced the test to only go back in history, to avoid dependency to the UITestContext.

Next, I will see whether we can reproduce zooming without requiring API level 14.

As for using different zooming levels per test page, I think this could be difficult to do, without making assumptions about the device resolutions.

Try push: https://tbpl.mozilla.org/?tree=Try&rev=67b9d03764ac
Attachment #8411072 - Attachment is obsolete: true
Status: ASSIGNED → NEW
Depends on: 1265818
No longer depends on: 1265818
We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → INCOMPLETE
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.