1000287 - Remove Log.w calls from GLController.java

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Toolbar, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

A while back while debugging GL issues in GLController.java we added a bunch of Log.w statements so we could get more info from crash reports. The issues seem to be resolved now so we can take out these log lines. The ones relating to egl preloading and eglInitialize can stay in, but the ones that are just tracing code (all the ones in serverSurfaceDestroyed, serverSurfaceChanged, updateCompositor, compositorCreated, and resumeCompositor) can be removed.

Comment 1

[Alex Deaconu]

Hi, I would like to work on this issue. Does it just involve the deletion of the Log lines?

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Yup, that's it! Have you successfully compiled and run the Fennec build? If so I can assign this bug to you and you can start working on it. If you haven't yet gotten it compiled and running, there are instructions to do so at https://wiki.mozilla.org/Mobile/Fennec/Android - please give that a go and let me know if you run into any problems!

Feel free to comment here, or join us in the #mobile channel on mozilla's IRC server (see https://wiki.mozilla.org/IRC) for help.

Comment 3

[Alex Deaconu]

Yes, I have compiled Fennec and using Eclipse as an IDE. I have also generated the eclipse projects and imported them into Eclipse.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Great! I'm assigning the bug to you.

Basically all you need to do is remove the log lines that I pointed out in comment 0 of this bug, make sure the code still compiles and runs fine, and then create a patch with your changes. Attach the patch to this bug as an attachment and flag me for review on it.

There are instructions on how to go about creating a patch at https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch#Creating_a_patch

As always, let me know if you have any questions or get stuck!

Comment 5

[Alex Deaconu]

Attachment: Removed unnecessary log lines from 'GLController'

Removed 'Log.w' lines from the 'serverSurfaceDestroyed', 'serverSurfaceChanged', 'updateCompositor', 'compositorCreated' and 'resumeCompositor' methods

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8411838 [details] [diff] [review]
Removed unnecessary log lines from 'GLController'

Review of attachment 8411838 [details] [diff] [review]:
-----------------------------------------------------------------

Perfect, thanks! That was really quick, good work :) I'll mark this bug for checkin and it will be closed when the patch gets merged to our mozilla-central repository. In the meantime please feel free to grab another bug to work on - let me know if you'd like me to point you to ones that might be a bit more interesting.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b170440acfed

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b170440acfed