[RTSP] Follow-up of 992568 - Remove obsolete codes to launch video app for RTSP

VERIFIED FIXED in 2.0 S2 (23may)

Status

defect
VERIFIED FIXED
5 years ago
4 years ago

People

(Reporter: ethan, Assigned: ethan)

Tracking

unspecified
2.0 S2 (23may)
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(tracking-b2g:backlog)

Details

(Whiteboard: [p=1])

Attachments

(2 attachments, 1 obsolete attachment)

Assignee

Description

5 years ago
This is a follow-up of bug 992568.

Since v2.0, we don't render RTSP in the video app anymore.
Those codes to launch the video app for RTSP by external helper should be removed.

Refer to bug 947132.
Assignee

Updated

5 years ago
Assignee: nobody → ettseng

Updated

5 years ago
blocking-b2g: --- → backlog
Assignee

Updated

5 years ago
Whiteboard: [p=1]
Target Milestone: --- → 2.0 S2 (23may)
Assignee

Comment 1

5 years ago
We should remove obsolete codes that were added from these bugs:
Bug 884702 - Make Rtsp non-exposed protocol and support rtsp in HTML <a> tag
Bug 947132 - [RTSP] Replace system message by activity when handing off rtsp URL loading
Bug 928332 - [RTSP][Gaia] Support RTSP in Video apps
Summary: [RTSP] Follow-up of 992568 - Remove codes to launch video app for RTSP → [RTSP] Follow-up of 992568 - Remove obsolete codes to launch video app for RTSP
Assignee

Updated

5 years ago
Status: NEW → ASSIGNED
Assignee

Comment 2

5 years ago
Remove those obsolete codes to send activity requests to launch the video app for RTSP. They were added by bug 884702 and 947132.

The preference "network.protocol-handler.expose.rtsp" is not needed as well since all protocol handlers are exposed by default.
Attachment #8425315 - Flags: review?(sworkman)
Assignee

Comment 3

5 years ago
Hi Steve,

This should be a trivial patch which just removes obsolete codes.
Could you help to review it?
Assignee

Comment 5

5 years ago
Comment on attachment 8425364 [details] [review]
Github pull request for master

Hi John,
This is a minor PR. Could you help to review it?
Attachment #8425364 - Flags: review?(johu)
Comment on attachment 8425364 [details] [review]
Github pull request for master

Thanks. This is a one line patch. Looks good.
Attachment #8425364 - Flags: review?(johu) → review+
Assignee

Comment 7

5 years ago
(In reply to John Hu [:johnhu][:johu][:醬糊小弟] from comment #6)
> Thanks. This is a one line patch. Looks good.

John, 
The Travis CI build had one failure which seems to be irrelevant to my patch.
https://travis-ci.org/mozilla-b2g/gaia/builds/25588342

Sorry I'm not familiar with hacking Gaia.
What should I do? Try to rebuild it or just ignore it?
Attachment #8425315 - Flags: review?(sworkman) → review+
Assignee

Comment 8

5 years ago
Refresh commit message "r=sworkman".
Attachment #8425315 - Attachment is obsolete: true
Assignee

Comment 9

5 years ago
> Created attachment 8425997 [details] [diff] [review]
Request to check in this patch.

This patch removes obsolete codes about RTSP and shouldn't affect anything else, however, it modifies source files of external helpers. Run full builds and tests for assurance.

The result of Try server:
https://tbpl.mozilla.org/?tree=Try&rev=36a549ae0cc9
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/b8da2f5209a9
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Verified. No side effect.
- http://goo.gl/MhBfUC

* Build Information:
 - Gaia a38a6a5c6fabc97dd16d5360632b5ac5c7e06241
 - Gecko https://hg.mozilla.org/mozilla-central/rev/951e3a671279
 - BuildID 20140604160202
 - Version 32.0a1
Status: RESOLVED → VERIFIED
Assignee

Comment 14

5 years ago
Thanks for verifying this, William.
blocking-b2g: backlog → ---
You need to log in before you can comment on or make changes to this bug.