1000340 - [RTSP] Follow-up of 992568 - Remove obsolete codes to launch video app for RTSP

Status: VERIFIED FIXED

(Firefox OS Graveyard :: RTSP, defect)

Description

[Ethan Tseng [:ethan]]

This is a follow-up of bug 992568.

Since v2.0, we don't render RTSP in the video app anymore.
Those codes to launch the video app for RTSP by external helper should be removed.

Refer to bug 947132.

Comment 1

[Ethan Tseng [:ethan]]

We should remove obsolete codes that were added from these bugs:
Bug 884702 - Make Rtsp non-exposed protocol and support rtsp in HTML <a> tag
Bug 947132 - [RTSP] Replace system message by activity when handing off rtsp URL loading
Bug 928332 - [RTSP][Gaia] Support RTSP in Video apps

Comment 2

[Ethan Tseng [:ethan]]

Attachment: Remove RTSP-related codes in external helper

Remove those obsolete codes to send activity requests to launch the video app for RTSP. They were added by bug 884702 and 947132.

The preference "network.protocol-handler.expose.rtsp" is not needed as well since all protocol handlers are exposed by default.

Comment 3

[Ethan Tseng [:ethan]]

Hi Steve,

This should be a trivial patch which just removes obsolete codes.
Could you help to review it?

Comment 4

[Ethan Tseng [:ethan]]

Attachment: Github pull request for master

Comment 5

[Ethan Tseng [:ethan]]

Comment on attachment 8425364 [details] [review]
Github pull request for master

Hi John,
This is a minor PR. Could you help to review it?

Comment 6

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8425364 [details] [review]
Github pull request for master

Thanks. This is a one line patch. Looks good.

Comment 7

[Ethan Tseng [:ethan]]

(In reply to John Hu [:johnhu][:johu][:醬糊小弟] from comment #6)
> Thanks. This is a one line patch. Looks good.

John, 
The Travis CI build had one failure which seems to be irrelevant to my patch.
https://travis-ci.org/mozilla-b2g/gaia/builds/25588342

Sorry I'm not familiar with hacking Gaia.
What should I do? Try to rebuild it or just ignore it?

Comment 8

[Ethan Tseng [:ethan]]

Attachment: Remove RTSP-related codes in external helper

Refresh commit message "r=sworkman".

Comment 9

[Ethan Tseng [:ethan]]

> Created attachment 8425997 [details] [diff] [review]
Request to check in this patch.

This patch removes obsolete codes about RTSP and shouldn't affect anything else, however, it modifies source files of external helpers. Run full builds and tests for assurance.

The result of Try server:
https://tbpl.mozilla.org/?tree=Try&rev=36a549ae0cc9

Comment 10

[John Hu [:johnhu][:johu][:醬糊小弟]]

merged to master:
https://github.com/mozilla-b2g/gaia/commit/b8c48cffaa746c539267c49b092bafec20794565

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/b8da2f5209a9

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b8da2f5209a9

Comment 13

[William Hsu [:whsu]]

Verified. No side effect.
- http://goo.gl/MhBfUC

* Build Information:
 - Gaia a38a6a5c6fabc97dd16d5360632b5ac5c7e06241
 - Gecko https://hg.mozilla.org/mozilla-central/rev/951e3a671279
 - BuildID 20140604160202
 - Version 32.0a1

Comment 14

[Ethan Tseng [:ethan]]

Thanks for verifying this, William.