Closed Bug 1000350 Opened 10 years ago Closed 10 years ago

don't overwrite a layout set display port base with a APZC-guessed one

Categories

(Core :: Layout, defect)

29 Branch
x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla31

People

(Reporter: tnikkel, Assigned: tnikkel)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
Bug 984460 comment 52.
Attachment #8411180 - Flags: review?(bugmail.mozilla)
Comment on attachment 8411180 [details] [diff] [review]
patch

Review of attachment 8411180 [details] [diff] [review]:
-----------------------------------------------------------------

Fine by me although I probably would have modified SetDisplayPortBase to take a priority value instead, to keep it parallel to SetDisplayPortMargins and SetDisplayPortForElement.
Attachment #8411180 - Flags: review?(bugmail.mozilla) → review+
That didn't occur to me. But it seems a little silly to keep a value around that we know is wrong. Also, how do we manage priority levels? AZPC for display port base uses 0, layout uses 1, testing using 2? It would get more confusing then it needs to be I think.
Yeah that's probably what I would have done (wrt managing priority levels). But it doesn't matter, you can land the patch you have. If we decide later we want something different it's not hard to change.
https://hg.mozilla.org/mozilla-central/rev/ce0bd55265b3
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in before you can comment on or make changes to this bug.