100048 - toshiba.no - JavaScript menus look all wrong

Status: RESOLVED WORKSFORME

(Tech Evangelism Graveyard :: Norwegian, defect, P3)

Description

[Toralf Lund]

The JavaScript menus on http://www.toshiba.no/ look all messed up; refer to
screenshot which will be attached shortly. This is true for the front page as
well as menus elsewhere on the site, with have different layout but (presumably)
a similar menu engine.

This problem may well be related to other reports about layers in menus, but I'm
submitting separately as these belong to different components (i.e. regions).
The existence of layer handling code is also what makes me think that the error
is with the web site, not the browser...

Comment 1

[Toralf Lund]

Attachment: Screen-shot of web page

Comment 2

[Toralf Lund]

The page definitely uses layers. However, it will conditionally try to use <div>
instead; the JavaScript code is full of constructs like

if(document.all)
	document.write('</div>')
else
	document.write('</layer>')

Perhaps all that is needed is to modify the tests so that they evaluate to true
on Mozilla?

Comment 3

[z-aillon.c-obsolete2]

http://www.toshiba.no/navet000203/main.html is the frame with the menus.  All
the code is based on if (document.all) {} else if (document.layers) {}

document.layers is MSIE specific which we don't support and document.layers is
NS4 specific which we don't support either.  They need to upgrade to DOM compliance.

Confirming bug on linux trunk 2001091721.

Comment 4

[Toralf Lund]

I'm assuming what you meant to say was that document.all (not document.layers)
MSIE specific.

Based on that, it seems to me that what their doing most of the time is really

if(<browser is MSIE>) {
  <add standard HTML>
} else { 
  <add Netscape Proprietary HTML>
}

which is rather dumb if you ask me (obviously, the standard stuff should
generally go in the "else" branch of browser tests.) It looks like there are
some truely MS specific bits as well, though...

Comment 5

[z-aillon.c-obsolete2]

their code uses MSIE specific (document.all which is what i meant to say above)
and NS4 specific (document.layers).  both are outdated.  the point is there is
no standard stuff in their code.  only MSIE and NS4 specific.

Comment 6

[Toralf Lund]

Well, they do in fact add <div> (that's a standard tag, right?) rather than
<layer) (which certainly isn't) if they think the browser is MSIE.

I guess that doesn't help a lot, though, as long as other parts of the code will
handle browser specific objects only.

Comment 7

[Tristan Nitot]

Confirming on N62/Win2K.
Accepting bug Setting P3.

Comment 8

[Kai Lahmann (is there, where MNG is)]

move..

Comment 9

[Bob Clary [:bc] (inactive)]

norwegian default owner

Comment 10

[Vidar Haarr (not reading bugmail)]

The site seems to work now.. I think they redesigned it.
I looked through the code and surfed around the site a bit, and it seems to work
OK now. It doesn't display as well as it should, but it's useable.

Comment 11

[alge]

Yup, redesigned. WFM.