Closed
Bug 1000483
Opened 10 years ago
Closed 10 years ago
CheckKeyUsage in pkixcheck.cpp in mozilla::pkix does not use its isTrustAnchor parameter
Categories
(Core :: Security: PSM, defect)
Core
Security: PSM
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: briansmith, Assigned: briansmith)
Details
Attachments
(1 file)
1.71 KB,
patch
|
cviecco
:
review+
|
Details | Diff | Splinter Review |
0:28.36 Warning: C4100 in c:\p\firefox\src\security\pkix\lib\pkixcheck.cpp: 'isTrustAnchor' : unreferenced formal parameter
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → brian
Target Milestone: --- → mozilla31
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8411366 -
Flags: review?(cviecco)
Comment 2•10 years ago
|
||
Comment on attachment 8411366 [details] [diff] [review] remove-unused-isTrustAnchor.patch Review of attachment 8411366 [details] [diff] [review]: ----------------------------------------------------------------- +r with comment addressed. ::: security/pkix/lib/pkixcheck.cpp @@ +45,5 @@ > const SECItem* encodedKeyUsage, > KeyUsages requiredKeyUsagesIfPresent, > PLArenaPool* arena) > { > if (!encodedKeyUsage) { update this comment too?
Attachment #8411366 -
Flags: review?(cviecco) → review+
Assignee | ||
Comment 3•10 years ago
|
||
(In reply to Camilo Viecco (:cviecco) from comment #2) > update this comment too? I updated the comment to refer to the bug about re-adding and actually using the isTrustAnchor parameter: bug 970196. Thanks for the review. https://hg.mozilla.org/integration/mozilla-inbound/rev/375a5b87253c
Status: NEW → ASSIGNED
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/375a5b87253c
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: mozilla31 → mozilla32
You need to log in
before you can comment on or make changes to this bug.
Description
•