1000483 - CheckKeyUsage in pkixcheck.cpp in mozilla::pkix does not use its isTrustAnchor parameter

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

0:28.36 Warning: C4100 in c:\p\firefox\src\security\pkix\lib\pkixcheck.cpp: 'isTrustAnchor' : unreferenced formal parameter

Comment 1

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Attachment: remove-unused-isTrustAnchor.patch

Comment 2

[Camilo Viecco (:cviecco)]

Comment on attachment 8411366 [details] [diff] [review]
remove-unused-isTrustAnchor.patch

Review of attachment 8411366 [details] [diff] [review]:
-----------------------------------------------------------------

+r with comment addressed.

::: security/pkix/lib/pkixcheck.cpp
@@ +45,5 @@
>                const SECItem* encodedKeyUsage,
>                KeyUsages requiredKeyUsagesIfPresent,
>                PLArenaPool* arena)
>  {
>    if (!encodedKeyUsage) {

update this comment too?

Comment 3

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

(In reply to Camilo Viecco (:cviecco) from comment #2)
> update this comment too?

I updated the comment to refer to the bug about re-adding and actually using the isTrustAnchor parameter: bug 970196.

Thanks for the review.

https://hg.mozilla.org/integration/mozilla-inbound/rev/375a5b87253c

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/375a5b87253c