Closed Bug 1000483 Opened 5 years ago Closed 5 years ago

CheckKeyUsage in pkixcheck.cpp in mozilla::pkix does not use its isTrustAnchor parameter

Categories

(Core :: Security: PSM, defect, trivial)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED
mozilla32

People

(Reporter: briansmith, Assigned: briansmith)

Details

Attachments

(1 file)

0:28.36 Warning: C4100 in c:\p\firefox\src\security\pkix\lib\pkixcheck.cpp: 'isTrustAnchor' : unreferenced formal parameter
Assignee: nobody → brian
Target Milestone: --- → mozilla31
Comment on attachment 8411366 [details] [diff] [review]
remove-unused-isTrustAnchor.patch

Review of attachment 8411366 [details] [diff] [review]:
-----------------------------------------------------------------

+r with comment addressed.

::: security/pkix/lib/pkixcheck.cpp
@@ +45,5 @@
>                const SECItem* encodedKeyUsage,
>                KeyUsages requiredKeyUsagesIfPresent,
>                PLArenaPool* arena)
>  {
>    if (!encodedKeyUsage) {

update this comment too?
Attachment #8411366 - Flags: review?(cviecco) → review+
(In reply to Camilo Viecco (:cviecco) from comment #2)
> update this comment too?

I updated the comment to refer to the bug about re-adding and actually using the isTrustAnchor parameter: bug 970196.

Thanks for the review.

https://hg.mozilla.org/integration/mozilla-inbound/rev/375a5b87253c
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/375a5b87253c
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: mozilla31 → mozilla32
You need to log in before you can comment on or make changes to this bug.