1000613 - Small leak in txExecutionState

Status: RESOLVED FIXED

(Core :: XSLT, defect)

Description

[Andrew McCreight [:mccr8]]

Found by running crashtests under LSAN.

Direct leak of 24 byte(s) in 1 object(s) allocated from:
#0 0x4685c9 in __interceptor_malloc (/home/amccreight/mc/obj-x86_64-unknown-linux-gnu/dist/bin/firefox-bin+0x4685c9)
#1 0x7fc90aad8c1b in moz_xmalloc /home/amccreight/mc/memory/mozalloc/mozalloc.cpp:52
#2 0x7fc8fb175887 in operator new(unsigned long) /home/amccreight/mc/obj-x86_64-unknown-linux-gnu/dom/xslt/xslt/../../../dist/include/mozilla/mozalloc.h:201
#3 0x7fc8fb175887 in txExecutionState::init(txXPathNode const&, txOwningExpandedNameMap<txIGlobalParameter>*) /home/amccreight/mc/dom/xslt/xslt/txExecutionState.cpp:101
#4 0x7fc8fb1a4b18 in txMozillaXSLTProcessor::TransformToDoc(nsIDOMDocument**, bool) /home/amccreight/mc/dom/xslt/xslt/txMozillaXSLTProcessor.cpp:651
#5 0x7fc8fb1b198f in nsTransformBlockerEvent::Run() /home/amccreight/mc/dom/xslt/xslt/txMozillaXSLTProcessor.cpp:534
#6 0x7fc8f80eebec in nsThread::ProcessNextEvent(bool, bool*) /home/amccreight/mc/xpcom/threads/nsThread.cpp:699
#7 0x7fc8f7fd4340 in NS_ProcessNextEvent(nsIThread*, bool) /home/amccreight/mc/xpcom/glue/nsThreadUtils.cpp:263
#8 0x7fc8f88b76cf in mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*) /home/amccreight/mc/ipc/glue/MessagePump.cpp:95
#9 0x7fc8f88481e5 in MessageLoop::RunInternal() /home/amccreight/mc/ipc/chromium/src/base/message_loop.cc:226
#10 0x7fc8f88481e5 in MessageLoop::RunHandler() /home/amccreight/mc/ipc/chromium/src/base/message_loop.cc:219
#11 0x7fc8f88481e5 in MessageLoop::Run() /home/amccreight/mc/ipc/chromium/src/base/message_loop.cc:193
#12 0x7fc8fa7f08ab in nsBaseAppShell::Run() /home/amccreight/mc/widget/xpwidgets/nsBaseAppShell.cpp:164
#13 0x7fc8fcfcfba9 in nsAppStartup::Run() /home/amccreight/mc/toolkit/components/startup/nsAppStartup.cpp:278
#14 0x7fc8fce39ee4 in XREMain::XRE_mainRun() /home/amccreight/mc/toolkit/xre/nsAppRunner.cpp:4019
#15 0x7fc8fce3ad03 in XREMain::XRE_main(int, char**, nsXREAppData const*) /home/amccreight/mc/toolkit/xre/nsAppRunner.cpp:4088
#16 0x7fc8fce3b688 in XRE_main /home/amccreight/mc/toolkit/xre/nsAppRunner.cpp:4300
#17 0x47f1fd in do_main(int, char**, nsIFile*) /home/amccreight/mc/browser/app/nsBrowserApp.cpp:282
#18 0x47f1fd in main /home/amccreight/mc/browser/app/nsBrowserApp.cpp:643
#19 0x7fc9098abb04 in __libc_start_main /home/johns/AUR/glibc/src/glibc-2.19/csu/libc-start.c:285

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Deleting mInitialEvalContext in the txExecutionState dtor should do the trick.

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Sprlinkling some leak monitoring macros on the xpath/xslt code also would be nice :)

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: Don't leak txExecutionState::mInitialEvalContext.

Oops, I forgot about this.  Thanks for the analysis Jonas, that helped a lot!

try run: https://tbpl.mozilla.org/?tree=Try&rev=d4413e74602c

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/90b98c0ef815

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/90b98c0ef815