Closed Bug 1000675 Opened 6 years ago Closed 6 years ago

Fix a few stylistic issues in example codegen

Categories

(Core :: DOM: Core & HTML, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla31

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Details

Attachments

(1 file)

This came up in bug 995385.  Specifically:

* Addition of a trailing "__" to #ifndef guards on header files
* Use of "mozilla::dom::Key" instead of "Key" in argument types
* Inclusion of nsContentUtils.h in the generated .cpp

The second item on that list is due to us switching to nativeType in bug 804725 and not doing the prettification we do for return values.

Patch coming up.
Attachment #8411536 - Flags: review?(jst) → review+
https://hg.mozilla.org/mozilla-central/rev/2f394d14ac89
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.