1000678 - Don't initiate NFC sharing when on the browser start page

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect)

Description

[Alison Shiue]

Attachment: S__458768.jpg

Gaia      0a4d2dea25a7162ee43db3a0db817798b70e7521
Gecko     https://hg.mozilla.org/mozilla-central/rev/1ab07aa4d004
BuildID   20140422160202
Version   31.0a1

STR:
1. launch "settings" app for 2 phones
2. turn on "NFC" for 2 phones
3. launch "browser" from phone A (on browser Homepage page)
4. tap 2 phones

Expected result:
Browser Homepage page should not show shrinking UI because it could not be shared

Actual result:
Browser Homepage page show shrinking UI

Comment 1

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

Hi Candice,

I guess the mechanism should be on browser app, to determine whether it is a sharable content or not.

Comment 2

[Candice Serran (:cserran)]

Hey Wesley,

Ben will be taking a look at this in this sprint as we reviewed in sprint planning today and will be tracking

Comment 3

[Ken Chang[:kenkai]]

This bug blocks NFC 2.0 release.

Comment 4

[Garner Lee]

(In reply to Wesley Huang [:wesley_huang] from comment #1)
> Hi Candice,
> 
> I guess the mechanism should be on browser app, to determine whether it is a
> sharable content or not.

Yes, the NFC onpeerready callback that's being inspected should not be set if the app determines can't be shared in the current context.

Comment 5

[Ben Francis [:benfrancis]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/19450

Comment 6

[Dale Harvey (:daleharvey)]

Comment on attachment 8425654 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/19450

looks good, cheers

https://github.com/mozilla-b2g/gaia/commit/3c823798b638e637c6c1985d266b9510c58db553

Comment 7

[Alison Shiue]

Verified on
Gaia      7db23414f2d632f4d00b5023ac1090b6045dc5fd
Gecko     https://hg.mozilla.org/mozilla-central/rev/2619a4def1b9
BuildID   20140522160203
Version   32.0a1

Comment 8

[Shally Li（leave from Mozilla）]

Per comment 7, clear "verifyme".

Comment 9

[Shally Li（leave from Mozilla）]

Hi Reporter,

    I can repro this bug on latest Flame v2.0. Could you help with checking it again?

Thank you.

Repro STR:
1. Launch "Settings" app and turn on "NFC" for 2 phones.
2. Launch "Browser" on Flame v2.0(stay Browser Homepage page)
3. Tap 2 phones together.
**Browser Homepage page show shrinking UI. --KO

Flame v2.0 build:
Gaia-Rev        2989f2b2bd12fcc0e9c017d2db766e76a55873b8
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/b4c61fd1dcfc
Build-ID        20150126000204
Version         32.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150126.033406
FW-Date         Mon Jan 26 03:34:17 EST 2015
Bootloader      L1TC000118D0

Comment 10

[Shally Li（leave from Mozilla）]

Attachment: new_logcat_1305.txt

Comment 11

[Shally Li（leave from Mozilla）]

Attachment: new_video_v2.0.mp4

Add video and log.

Comment 12

[Alison Shiue]

Clone bug 1126249 to track this issue.

Comment 13

[Shine(Leave from Mozilla)]

According to https://bugzilla.mozilla.org/show_bug.cgi?id=1138508#c15, this problem have fixed on flame 3.0, set the Tracking Flag of Flame 3.0 to unaffected.