Closed
Bug 1000745
Opened 11 years ago
Closed 11 years ago
Remove obsolete font.mathfont-family* preferences
Categories
(Core :: MathML, defect)
Core
MathML
Tracking
()
RESOLVED
FIXED
mozilla31
People
(Reporter: fredw, Assigned: fredw)
References
Details
Attachments
(2 files, 4 obsolete files)
|
10.01 KB,
patch
|
Details | Diff | Splinter Review | |
|
4.67 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
Extracting that part from bug 947654...
|
Assignee | |
Comment 1•11 years ago
|
||
|
||
Comment 2•11 years ago
|
||
Is "font.mathfont-glyph-tables" also obsolete? There's no entry by that name in all.js.
|
|
Assignee | |
Comment 3•11 years ago
|
||
This does not change the style context.
Attachment #8411618 -
Attachment is obsolete: true
Attachment #8411618 -
Flags: review?(karlt)
Attachment #8411631 -
Flags: review?(karlt)
|
|
Assignee | |
Comment 4•11 years ago
|
||
Attachment #8411631 -
Attachment is obsolete: true
Attachment #8411631 -
Flags: review?(karlt)
Attachment #8411633 -
Flags: review?(karlt)
|
|
Assignee | |
Comment 5•11 years ago
|
||
Sorry to mix up with the patches. Hopefully that version is the right one.
Attachment #8411633 -
Attachment is obsolete: true
Attachment #8411633 -
Flags: review?(karlt)
Attachment #8411637 -
Flags: review?(karlt)
|
||
Updated•11 years ago
|
Attachment #8411637 -
Flags: review?(karlt) → review+
|
|
Assignee | |
Comment 6•11 years ago
|
||
(In reply to John Daggett (:jtd) away 25 - 29 april from comment #2)
> Is "font.mathfont-glyph-tables" also obsolete? There's no entry by that name
> in all.js.
So reading again, I see that font.mathfont-glyph-tables is only used with EnumerateFamilies to register the private glyph tables. I think we can just remove it and do calls with hardcoded family-name
gGlyphTableList->AddGlyphTable("MathJax_Main")
gGlyphTableList->AddGlyphTable("STIXNonUnicode")
etc
until we remove deprecate these fonts and remove these old tables.
|
|
Assignee | |
Comment 7•11 years ago
|
||
Attachment #8411637 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 8•11 years ago
|
||
This patch removes font.mathfont-glyph-tables and should be yet another perf improvement, since we no longer need to read the mathfont.property file at init.
That seems to work for me (tested with STIX & MathJax).
My only concern is if EnumerateFamilies does some magic to determine the family string (I'm assuming it only splits the list).
Attachment #8411676 -
Flags: review?(karlt)
Attachment #8411676 -
Flags: feedback?(jdaggett)
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8411676 -
Flags: review?(roc)
Attachment #8411676 -
Flags: review?(roc) → review+
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8411676 -
Flags: review?(karlt)
Attachment #8411676 -
Flags: feedback?(jdaggett)
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 9•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/7564b6bb7720
https://hg.mozilla.org/integration/mozilla-inbound/rev/570a6e27b76e
Keywords: checkin-needed
|
|
||
Comment 10•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7564b6bb7720
https://hg.mozilla.org/mozilla-central/rev/570a6e27b76e
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in
before you can comment on or make changes to this bug.
Description
•