Remove obsolete font.mathfont-family* preferences

RESOLVED FIXED in mozilla31

Status

()

defect
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: fredw, Assigned: fredw)

Tracking

Trunk
mozilla31
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 4 obsolete attachments)

Extracting that part from bug 947654...
Posted patch Patch (obsolete) — Splinter Review
Assignee: nobody → fred.wang
Status: NEW → ASSIGNED
Attachment #8411618 - Flags: review?(karlt)
Is "font.mathfont-glyph-tables" also obsolete? There's no entry by that name in all.js.
Posted patch Patch (obsolete) — Splinter Review
This does not change the style context.
Attachment #8411618 - Attachment is obsolete: true
Attachment #8411618 - Flags: review?(karlt)
Attachment #8411631 - Flags: review?(karlt)
Posted patch Patch (obsolete) — Splinter Review
Attachment #8411631 - Attachment is obsolete: true
Attachment #8411631 - Flags: review?(karlt)
Attachment #8411633 - Flags: review?(karlt)
Posted patch Patch (obsolete) — Splinter Review
Sorry to mix up with the patches. Hopefully that version is the right one.
Attachment #8411633 - Attachment is obsolete: true
Attachment #8411633 - Flags: review?(karlt)
Attachment #8411637 - Flags: review?(karlt)
Attachment #8411637 - Flags: review?(karlt) → review+
(In reply to John Daggett (:jtd) away 25 - 29 april from comment #2)
> Is "font.mathfont-glyph-tables" also obsolete? There's no entry by that name
> in all.js.

So reading again, I see that font.mathfont-glyph-tables is only used with EnumerateFamilies to register the private glyph tables. I think we can just remove it and do calls with hardcoded family-name

gGlyphTableList->AddGlyphTable("MathJax_Main")
gGlyphTableList->AddGlyphTable("STIXNonUnicode")
etc

until we remove deprecate these fonts and remove these old tables.
This patch removes font.mathfont-glyph-tables and should be yet another perf improvement, since we no longer need to read the mathfont.property file at init.

That seems to work for me (tested with STIX & MathJax).

My only concern is if EnumerateFamilies does some magic to determine the family string (I'm assuming it only splits the list).
Attachment #8411676 - Flags: review?(karlt)
Attachment #8411676 - Flags: feedback?(jdaggett)
Attachment #8411676 - Flags: review?(roc)
Attachment #8411676 - Flags: review?(karlt)
Attachment #8411676 - Flags: feedback?(jdaggett)
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/7564b6bb7720
https://hg.mozilla.org/mozilla-central/rev/570a6e27b76e
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
Blocks: 1177093
You need to log in before you can comment on or make changes to this bug.