Closed
Bug 1000973
Opened 11 years ago
Closed 11 years ago
Issues with the animation in the "Tabs you can feel" section of Fast at the new Australis site
Categories
(www.mozilla.org :: Pages & Content, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jaws, Assigned: jpetto)
References
(Blocks 1 open bug)
Details
(Whiteboard: [kb=1345494])
Attachments
(1 file)
STR:
Go to https://www-demo4.allizom.org/en-US/firefox/desktop/fast/
Scroll down to the "Tabs you can feel" section
Watch the animation
The animation shows a new tab being created, although to me it looks odd because we show the close button for the background tab but there is no title for the background tab, so it just looks like a random floating close button. We could solve this by putting a tab title alongside that close button (even something such as "Firefox Home Page").
Also, on HiDPI screens, there is a visible gap between the tab and the navigation toolbar, as seen in this screenshot: http://screencast.com/t/8BwhTJxr
Reporter | ||
Updated•11 years ago
|
Version: Production → Development/Staging
Assignee | ||
Updated•11 years ago
|
Whiteboard: [kb=1345494]
Updated•11 years ago
|
Comment 1•11 years ago
|
||
The hairline visible gap is a quick fix, but the tab title has both creative and l10n implications.
Ty, any recommendations for this one?
Flags: needinfo?(tflanagan)
Comment 2•11 years ago
|
||
Hmm, its a challenging one since we are trying to avoid adding any copy into these visuals. Ill give it some thought and tinker with the PSD to see what we can do.
Flags: needinfo?(tflanagan)
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → jon
Assignee | ||
Comment 3•11 years ago
|
||
PR added for the hairline gap. As noted in the PR:
Chrome on OS X (release & Canary) is adding a weird 1px white inset border-ish thing to the tab on my MBP retina display. The bug doesn't appear on a standard resolution monitor. I spent a bit of time researching and trying little fixes, but nothing got rid of it. Looks fine in all other browsers. Didn't think it was worth more than 30 minutes, but worth mentioning.
Comment 4•11 years ago
|
||
Commits pushed to master at https://github.com/mozilla/bedrock
https://github.com/mozilla/bedrock/commit/d224b3a40323b57e1d00478ece7daebaf294171f
Update Fx desktop fast tab animation. Bug 1000973.
- Move the tabs down one pixel to fill gap noticeable
on high resolution displays.
https://github.com/mozilla/bedrock/commit/975fb6e3050742d9cf5c4b66aa248844322870ad
Merge pull request #2086 from jpetto/bug-1000973-fx-desktop-fast-animation-image-update
Update Fx desktop fast tab animation. Bug 1000973.
Comment 5•11 years ago
|
||
Closing as per Comment 4.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•