Closed Bug 1000984 Opened 10 years ago Closed 10 years ago

[Camera] Pinch-to-zoom gesture should be attached to the |window| object in the DOM

Categories

(Firefox OS Graveyard :: Gaia::Camera, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Camera
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:1.4+, b2g-v1.4 fixed, b2g-v2.0 fixed)

Status:
RESOLVED FIXED
Milestone:
2.0 S1 (9may)
Project Flags:
blocking-b2g 1.4+
Tracking Flags:
Tracking Status
b2g-v1.4 --- fixed
b2g-v2.0 --- fixed

People

(Reporter: justindarc, Assigned: justindarc)

References

Details

Attachments

(2 files)

pull-request (master)
46 bytes, text/x-github-pull-request
dmarcos
: review+
wilsonpage
: feedback-
Details | Review
pull-request (v1.4)
46 bytes, text/x-github-pull-request
justindarc
: review+
Details | Review 
Currently, the Camera app listens for the pinch-to-zoom gesture on the viewfinder element. For a better experience, it should be attached to the `window` object so that all touches (regardless of their source element) will bubble up to the `window`. This should help especially with smaller-screen devices such as the Hamachi.
Summary: Pinch-to-zoom gesture should be attached to the |window| object in the DOM → [Camera] Pinch-to-zoom gesture should be attached to the |window| object in the DOM
Assignee: nobody → jdarcangelo
The App element is probably the best place to listen for this.
Attached file pull-request (master) — 
Wilson: This isn't complete yet, but I wanted to get your feedback before I go much further with it. Thanks!
Attachment #8413769 - Flags: feedback?(wilsonpage)
Attachment #8413769 - Flags: feedback?(dmarcos)
Comment on attachment 8413769 [details] [review]
pull-request (master)

- See Github comments/nits
- Unit-tests required
Attachment #8413769 - Flags: feedback?(wilsonpage) → feedback-
Blocks: 995475
Comment on attachment 8413769 [details] [review]
pull-request (master)

Diego: Please review. I addressed feedback from you and Wilson and also added a bunch of unit tests for lib/pinch.js
Attachment #8413769 - Flags: feedback?(dmarcos) → review?(dmarcos)
Comment on attachment 8413769 [details] [review]
pull-request (master)

Everything looks great to me except the old problem of event names inconsistency. I think we need some discipline and start using only past tense across all event names.
Attachment #8413769 - Flags: review?(dmarcos) → review+
Landed on master:

https://github.com/mozilla-b2g/gaia/commit/60eed1a3d1cbb4939eebd637a53543356432c3b6
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Blocking a blocker...1.4+
blocking-b2g: --- → 1.4+
Needs rebasing for v1.4 uplift.
status-b2g-v1.4: --- → affected
status-b2g-v2.0: --- → fixed
Flags: needinfo?(jdarcangelo)
Keywords: branch-patch-needed
Target Milestone: --- → 2.0 S1 (9may)
Attached file pull-request (v1.4) — 
Pull request for v1.4 -- carrying R+ forward
Attachment #8416152 - Flags: review+
Flags: needinfo?(jdarcangelo)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: