1001009 - Very long button text

Status: VERIFIED FIXED

(Marketplace Graveyard :: Developer Pages, defect, P5)

Description

[Andy McKay]

This button text is rather long. But it's really just a link to page that tells you more, its not a button that does a POST or a form submit.

Maybe some text followed by a link would be more appropriate.

https://www.dropbox.com/s/tz633kg9wqy7972/Screenshot%202014-04-24%2010.39.26.png

Comment 1

[Ram Dayal Vaishnav [:ram]]

Can I give it a try ?

Comment 2

[Andy McKay]

Please do.

Comment 3

[Ram Dayal Vaishnav [:ram]]

Andy, thanks for assigning this bug to me, but I have fixed bugs in Firefox OS only till now. This bug looks 'good first bug' for Marketplace Bugs, kindly help me in how to get started. Thanks!

Comment 4

[Andy McKay]

This button is on a page served by zamboni, marketplace docs are here:

http://marketplace.readthedocs.org/en/latest/

The code for that button looks like its here:

https://github.com/mozilla/zamboni/blob/master/mkt/developers/templates/developers/apps/status.html#L156-L163

Comment 5

[Andy McKay]

Lets just change it to a link.

Comment 6

[Ram Dayal Vaishnav [:ram]]

Hi Andy, I am working on this now (sorry for being too late). Can you give me some other links also from where I can better and easily get instructions about setting up the marketplace environment on my system. I am a newbie, so not getting clear list of steps for this.

Comment 7

[Andy McKay]

Documentation is at: http://marketplace.readthedocs.org/en/latest/

Comment 8

[Ram Dayal Vaishnav [:ram]]

Hi Andy,

I am facing couple of issues in bringing local instance of marketplace. I followed the documentation whose link is given in Comment 7 above. I am assuming that I need to install fireplace only as of now. While installing fireplace, the command 3 (npm install -g commonplace) mentioned at [1] gives me following warning..

   npm WARN optional dep failed, continuing fsevents@0.2.1

The command 4 also did not run because I was not getting the file src/media/js/settings_flue_paas.js.dist. Then I refered to [2], and I tried giving following command instead..
 
   cp hearth/media/js/settings_local.js.dist hearth/media/js/settings_local.js

After this, when I try giving command 5 (damper), I am getting following error..

   No commonplace installation found.


[1] http://marketplace.readthedocs.org/en/latest/topics/setup.html#install-fireplace
[2] https://wiki.mozilla.org/Fireplace/Configuring

Comment 9

[Christopher Van Wiemeersch [:cvan]]

>   npm WARN optional dep failed, continuing fsevents@0.2.1

That's a warning, not an error. So it's free to ignore.

> The command 4 also did not run because I was not getting the file src/media/js/settings_flue_paas.js.dist. 

Oops, a while back we renamed `hearth/` to `src/` but forgot to update the docs. I just fixed the docs now:

    http://marketplace.readthedocs.org/en/latest/topics/setup.html#install-fireplace
    https://github.com/mozilla/marketplace-docs/commit/c38e463

> After this, when I try giving command 5 (damper), I am getting following error..
>
>    No commonplace installation found.

You should run `damper` from the root directory (e.g., ~/projects/fireplace/) not from the `src` directory (e.g., ~/projects/fireplace/src/). If you can paste your bash session, that'd help.

Comment 10

[Ram Dayal Vaishnav [:ram]]

Thanks Christopher,
I am still facing the last issue, i.e., not able to run 'damper' command.

Here are the logs..

ram@mani-RV409-RV509-RV709:~/MarketplaceHack$ cd fireplace

ram@mani-RV409-RV509-RV709:~/MarketplaceHack/fireplace$ npm install

ram@mani-RV409-RV509-RV709:~/MarketplaceHack/fireplace$ npm install -g commonplace
npm ERR! error rolling back Error: EACCES, unlink '/usr/bin/damper'
npm ERR! error rolling back  commonplace@0.4.22 { [Error: EACCES, unlink '/usr/bin/damper'] errno: 3, code: 'EACCES', path: '/usr/bin/damper' }
npm ERR! Error: EACCES, unlink '/usr/bin/damper'
npm ERR!  { [Error: EACCES, unlink '/usr/bin/damper'] errno: 3, code: 'EACCES', path: '/usr/bin/damper' }
npm ERR! 
npm ERR! Please try running this command again as root/Administrator.

npm ERR! System Linux 3.13.0-30-generic
npm ERR! command "/usr/bin/node" "/usr/bin/npm" "install" "-g" "commonplace"
npm ERR! cwd /home/ram/MarketplaceHack/fireplace
npm ERR! node -v v0.10.31
npm ERR! npm -v 1.4.23
npm ERR! path /usr/bin/damper
npm ERR! code EACCES
npm ERR! errno 3
npm ERR! stack Error: EACCES, unlink '/usr/bin/damper'
npm ERR! 
npm ERR! Additional logging details can be found in:
npm ERR!     /home/ram/MarketplaceHack/fireplace/npm-debug.log
npm ERR! not ok code 0

ram@mani-RV409-RV509-RV709:~/MarketplaceHack/fireplace$ sudo npm install -g commonplace
npm WARN optional dep failed, continuing fsevents@0.2.1
/usr/bin/damper -> /usr/lib/node_modules/commonplace/bin/damper
/usr/bin/commonplace -> /usr/lib/node_modules/commonplace/bin/commonplace
commonplace@0.4.22 /usr/lib/node_modules/commonplace
├── clean-css@2.0.8 (commander@2.0.0)
├── uglify-js@2.4.15 (uglify-to-browserify@1.0.2, async@0.2.10, optimist@0.3.7, source-map@0.1.34)
├── stylus@0.32.1 (mkdirp@0.3.5, cssom@0.2.5, debug@2.0.0)
├── jshint@2.3.0 (console-browserify@0.1.6, underscore@1.4.4, shelljs@0.1.4, minimatch@0.4.0, cli@0.4.5)
└── nunjucks@1.0.7 (optimist@0.6.1, chokidar@0.8.4)

ram@mani-RV409-RV509-RV709:~/MarketplaceHack/fireplace$ cp hearth/media/js/settings_local.js.dist hearth/media/js/settings_package_local.js

ram@mani-RV409-RV509-RV709:~/MarketplaceHack/fireplace$ damper
No commonplace installation found.

ram@mani-RV409-RV509-RV709:~/MarketplaceHack/fireplace$ sudo damper
No commonplace installation found.

Comment 11

[Christopher Van Wiemeersch [:cvan]]

> ram@mani-RV409-RV509-RV709:~/MarketplaceHack$ cd fireplace

Did you already clone the project there? Can you `ls` the directory to show me which files are in there?

> cp hearth/media/js/settings_local.js.dist hearth/media/js/settings_package_local.js

Per my comment above, you shouldn't be typing `hearth`. You should be typing `src`.

Stuart and Mat run Fireplace on Linux. Do you guys have any ideas here?

Comment 12

[Mathieu Pillard [:mat]]

I am not sure what's going on. You shouldn't need to sudo damper, it should just work from that directory without special privileges.

Note that this bug is about something in the developer pages, so you technically don't need fireplace to fix it, only zamboni.

Comment 13

[Ram Dayal Vaishnav [:ram]]

(In reply to Mathieu Pillard [:mat] from comment #12)
> Note that this bug is about something in the developer pages, so you
> technically don't need fireplace to fix it, only zamboni.

Thanks Mathieu, I will try to install zamboni now.

Comment 14

[Ram Dayal Vaishnav [:ram]]

Hey, I am trying to follow steps from http://zamboni.readthedocs.org/en/latest/topics/install-zamboni/installation.html#on-ubuntu, but not able to proceed with Step 4 : Getting Packages.


Here are logs..

ram@mani-RV409-RV509-RV709:~$ sudo aptitude install python-dev python-virtualenv libxml2-dev libxslt1-dev libmysqlclient-dev libssl-dev swig openssl curl pngcrush redis-server
No packages will be installed, upgraded, or removed.
0 packages upgraded, 0 newly installed, 0 to remove and 197 not upgraded.
Need to get 0 B of archives. After unpacking 0 B will be used.
                                         
ram@mani-RV409-RV509-RV709:~$ cd MarketplaceHack/zamboni/

ram@mani-RV409-RV509-RV709:~/MarketplaceHack/zamboni$ ls
apps     CONTRIBUTING.md  fabfile.py   LICENSE   manage.py   mkt           requirements  settings_test.py  tmp
bin      Dockerfile       __init__.py  locale    media       package.json  scripts       sites             vendor
configs  docs             lib          Makefile  migrations  README.md     services      templates         wsgi

ram@mani-RV409-RV509-RV709:~/MarketplaceHack/zamboni$ curl -s https://raw.github.com/brainsik/virtualenv-burrito/master/virtualenv-burrito.sh | $SHELL

ram@mani-RV409-RV509-RV709:~/MarketplaceHack/zamboni$ mkvirtualenv --python=python2.6 zamboni
mkvirtualenv: command not found

Comment 15

[Ram Dayal Vaishnav [:ram]]

Hi All,

I am stuck at above (comment14) while setting up zamboni. Please advice!

I was also trying to setup Docker for some other bug, can I can fix this through Docker ?

Thanks,
Ram

Comment 16

[Wil Clouser [:clouserw]]

Yes, you can use docker here and that's the best path.

To answer your question in comment 14, the last lines of the script you ran from github.com prints instructions to the console.  It says you must run `source $VENVBURRITO/startup.sh` to continue.  Once you do that, you'll have a mkvirtualenv command.

Comment 17

[Ram Dayal Vaishnav [:ram]]

Hi Wil,

I have set up the local instance using docker and have submitted one app, but this is being shown as Pending-approval, how do we set it to approved app ?

I need this because I guess the button (https://www.dropbox.com/s/tz633kg9wqy7972/Screenshot%202014-04-24%2010.39.26.png) will appear only after the app is approved.

Thanks,
Ram Vaishnav

Comment 18

[Wil Clouser [:clouserw]]

going to /reviewers/ should show you the review queue and let you approve it.

Comment 19

[Ram Dayal Vaishnav [:ram]]

Attachment: patch-screenshot.png

After the patch it will look like this. Do you have any other recommendation about the text that should appear there.

Comment 20

[Ram Dayal Vaishnav [:ram]]

Created Pull Request - https://github.com/mozilla/zamboni/pull/2939. Kindly review.

Thanks,
Ram

Comment 21

[Andy McKay]

There's been some comments on the pull request.

Comment 22

[Ram Dayal Vaishnav [:ram]]

https://github.com/mozilla/zamboni/pull/2948

Comment 23

[Ram Dayal Vaishnav [:ram]]

As suggested by diox in above PR, we should not split parts of the same sentence into multiple _() calls.

Currently following string is set as button text - 
_('Learn how to get your app pre-installed on Firefox OS devices')

Please suggest me how to divide it in parts, so that it does not become difficult to translate.

Comment 24

[Ram Dayal Vaishnav [:ram]]

Submitted another commit - https://github.com/mozilla/zamboni/commit/b964c5e0e451202635ff64092f9f48e711ff2441

Kindly review.

Comment 25

[Wil Clouser [:clouserw]]

Thanks Ram!  Landed in https://github.com/mozilla/zamboni/commit/c8544fe9e3bc9cc1c72029844bb4466b1ac5dda9

Comment 26

[Madalin Cotetiu]

Verified as fixed in mp-dev FF40(Win7)
Postfix screencast: http://screencast.com/t/adBWVR2dpcS
Closing bug.