Closed Bug 1001049 Opened 7 years ago Closed 7 years ago
npm install fails on 1
46 bytes, text/x-github-pull-request
|Details | Review|
This is causing perma-red in Travis. npm ERR! peerinvalid The package marionette-client does not satisfy its siblings' peerDependencies requirements! npm ERR! peerinvalid Peer email@example.com wants marionette-client@>=1.1.6 npm ERR! peerinvalid Peer firstname.lastname@example.org wants marionette-client@>=1.1.0 npm ERR! peerinvalid Peer email@example.com wants marionette-client@>=1.0.0
The problem is that for marionette-apps, we specify version '~0.3.3', which will actually fetch '0.3.4' based on semvar rules. We need to specify '0.3.3' instead.
Comment on attachment 8412036 [details] [review] Github PR, use specific version of marionette apps LGTM. Thanks :mhenretty!
Attachment #8412036 - Flags: review?(gaye) → review+
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
v1.3 actually had the same issue, so I applied it there too: v1.3: 12383b1282a960c0cbde1c1c45b0ce0f1cb7cac7 Thanks for applying the fix beforehand, it was easier for me ;)
You need to log in before you can comment on or make changes to this bug.