100113 - nsIContentViewerFile.h (webshell) brings in nsIDeviceContext.h (gfx)

Status: RESOLVED FIXED

(Core :: Layout, defect, P2)

Description

[Alec Flett]

this is a nasty dependency. this means anyone that requires webshell also
requires gfx!

Comment 1

[Alec Flett]

nsIContentViewerFile only needs nsIDeviceContext.h for printing:
  NS_IMETHOD PrintContent(nsIWebShell *      aParent,
                          nsIDeviceContext * aDContext,
                          nsIDOMWindow     * aDOMWin,
                          PRBool             aIsSubDoc) = 0;

I'm going to try forward-declaring it.
If that doesn't break enough dependencies, we might consider moving this to a
new interface, a la nsIContentViewerPrint or something.

Comment 2

[Alec Flett]

Attachment: forward-declare. works ok on windows! :)

Comment 3

[Alec Flett]

ran out of time to test this on other platforms.. moving to 0.9.6

Comment 4

[Alec Flett]

Attachment: full patch

Comment 5

[jag (Peter Annema)]

Comment on attachment 55858 [details] [diff] [review]
full patch

r=jag

Comment 6

[Christopher Blizzard (:blizzard)]

Comment on attachment 55858 [details] [diff] [review]
full patch

sr=blizzard

Comment 7

[Alec Flett]

cool! patches are in. thanks guys