Closed Bug 100113 Opened 23 years ago Closed 23 years ago

nsIContentViewerFile.h (webshell) brings in nsIDeviceContext.h (gfx)

Categories

(Core :: Layout, defect, P2)

x86
Windows 2000
defect

Tracking

()

RESOLVED FIXED
mozilla0.9.6

People

(Reporter: alecf, Assigned: alecf)

References

Details

(Whiteboard: fix in hand)

Attachments

(1 file, 1 obsolete file)

this is a nasty dependency. this means anyone that requires webshell also
requires gfx!
Blocks: 100107
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.5
nsIContentViewerFile only needs nsIDeviceContext.h for printing:
  NS_IMETHOD PrintContent(nsIWebShell *      aParent,
                          nsIDeviceContext * aDContext,
                          nsIDOMWindow     * aDOMWin,
                          PRBool             aIsSubDoc) = 0;

I'm going to try forward-declaring it.
If that doesn't break enough dependencies, we might consider moving this to a
new interface, a la nsIContentViewerPrint or something.
Priority: -- → P2
Whiteboard: fix in hand
Priority: P2 → P3
ran out of time to test this on other platforms.. moving to 0.9.6
Priority: P3 → P2
Target Milestone: mozilla0.9.5 → mozilla0.9.6
Depends on: 106686
No longer blocks: 100107
Attached patch full patchSplinter Review
Attachment #50960 - Attachment is obsolete: true
Comment on attachment 55858 [details] [diff] [review]
full patch

r=jag
Attachment #55858 - Flags: review+
Comment on attachment 55858 [details] [diff] [review]
full patch

sr=blizzard
Attachment #55858 - Flags: superreview+
cool! patches are in. thanks guys
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: