If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

nsIContentViewerFile.h (webshell) brings in nsIDeviceContext.h (gfx)

RESOLVED FIXED in mozilla0.9.6

Status

()

Core
Layout
P2
normal
RESOLVED FIXED
16 years ago
16 years ago

People

(Reporter: Alec Flett, Assigned: Alec Flett)

Tracking

Trunk
mozilla0.9.6
x86
Windows 2000
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fix in hand)

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

16 years ago
this is a nasty dependency. this means anyone that requires webshell also
requires gfx!
(Assignee)

Updated

16 years ago
Blocks: 100107
Status: NEW → ASSIGNED
(Assignee)

Updated

16 years ago
Target Milestone: --- → mozilla0.9.5
(Assignee)

Comment 1

16 years ago
nsIContentViewerFile only needs nsIDeviceContext.h for printing:
  NS_IMETHOD PrintContent(nsIWebShell *      aParent,
                          nsIDeviceContext * aDContext,
                          nsIDOMWindow     * aDOMWin,
                          PRBool             aIsSubDoc) = 0;

I'm going to try forward-declaring it.
If that doesn't break enough dependencies, we might consider moving this to a
new interface, a la nsIContentViewerPrint or something.
(Assignee)

Comment 2

16 years ago
Created attachment 50960 [details] [diff] [review]
forward-declare. works ok on windows! :)
(Assignee)

Updated

16 years ago
Priority: -- → P2
Whiteboard: fix in hand
(Assignee)

Updated

16 years ago
Priority: P2 → P3
(Assignee)

Comment 3

16 years ago
ran out of time to test this on other platforms.. moving to 0.9.6
Priority: P3 → P2
Target Milestone: mozilla0.9.5 → mozilla0.9.6
(Assignee)

Updated

16 years ago
Depends on: 106686
(Assignee)

Updated

16 years ago
No longer blocks: 100107
(Assignee)

Comment 4

16 years ago
Created attachment 55858 [details] [diff] [review]
full patch
(Assignee)

Updated

16 years ago
Attachment #50960 - Attachment is obsolete: true

Comment 5

16 years ago
Comment on attachment 55858 [details] [diff] [review]
full patch

r=jag
Attachment #55858 - Flags: review+
Comment on attachment 55858 [details] [diff] [review]
full patch

sr=blizzard
Attachment #55858 - Flags: superreview+
(Assignee)

Comment 7

16 years ago
cool! patches are in. thanks guys
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.