Closed Bug 1001157 Opened 6 years ago Closed 6 years ago

Assert in bindings code if there is a pending exception on the cx but no corresponding error marked on the ErrorResult

Categories

(Core :: DOM: Core & HTML, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla32

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Details

Attachments

(1 file)

And in particular, we need to assert if there is an exception pending but the method/property is not marked [Throws].
Have you pushed this to try?  I wonder how many existing issues this will uncover!
I thought I had, but it looks like I accidentally did an opt push, which is not helpful. Doing another try push now (linux-only, since we don't have debug b2g coverage anyway).
I suppose I could do a MOZ_CRASH + try run on all platforms...
(In reply to comment #4)
> I suppose I could do a MOZ_CRASH + try run on all platforms...

Why would we use MOZ_CRASH?
We wouldn't use it in production.  We'd use it in a try run to cause failures even on b2g, where we only run tests on opt builds.
Incidentally, my try run is at https://tbpl.mozilla.org/?tree=Try&rev=90a639fc29d6
Attachment #8412159 - Flags: review?(peterv) → review+
None of those failures were from this patch.  Relanded: https://hg.mozilla.org/integration/mozilla-inbound/rev/823c0199a31d
Flags: needinfo?(bzbarsky) → in-testsuite+
Whiteboard: [need review]
https://hg.mozilla.org/mozilla-central/rev/823c0199a31d
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.