1001157 - Assert in bindings code if there is a pending exception on the cx but no corresponding error marked on the ErrorResult

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

And in particular, we need to assert if there is an exception pending but the method/property is not marked [Throws].

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Assert that there is no exception pending on the JSContext afer a DOM call if the call was not marked as throwing or if it did not throw on the ErrorResult

Comment 2

[(no longer active)]

Have you pushed this to try?  I wonder how many existing issues this will uncover!

Comment 3

[Boris Zbarsky [:bzbarsky]]

I thought I had, but it looks like I accidentally did an opt push, which is not helpful. Doing another try push now (linux-only, since we don't have debug b2g coverage anyway).

Comment 4

[Boris Zbarsky [:bzbarsky]]

I suppose I could do a MOZ_CRASH + try run on all platforms...

Comment 5

[(no longer active)]

(In reply to comment #4)
> I suppose I could do a MOZ_CRASH + try run on all platforms...

Why would we use MOZ_CRASH?

Comment 6

[Boris Zbarsky [:bzbarsky]]

We wouldn't use it in production.  We'd use it in a try run to cause failures even on b2g, where we only run tests on opt builds.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Incidentally, my try run is at https://tbpl.mozilla.org/?tree=Try&rev=90a639fc29d6

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed this out in http://hg.mozilla.org/integration/mozilla-inbound/rev/c46fb6bada28 along with backing out bug 997285 for various busted things: 
https://tbpl.mozilla.org/php/getParsedLog.php?id=39073608&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=39073379&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=39073678&tree=Mozilla-Inbound

Comment 9

[Boris Zbarsky [:bzbarsky]]

None of those failures were from this patch.  Relanded: https://hg.mozilla.org/integration/mozilla-inbound/rev/823c0199a31d

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/823c0199a31d