FxAccountsManager.jsm should correctly handle {refreshAuthentication:0} from mozId.request()

RESOLVED FIXED

Status

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: spenrose, Assigned: spenrose)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Assignee

Description

5 years ago
I made a silly mistake in the existing code, casting refreshAuthentication to a boolean to see if it exists. Short patch coming for review.
Assignee

Updated

5 years ago
Blocks: 1000323
Assignee

Comment 1

5 years ago
Posted patch 1001182-refreshAuth.patch (obsolete) — Splinter Review
Fun with casting to boolean.
Attachment #8412198 - Flags: review?(jparsons)
Assignee

Updated

5 years ago
Blocks: 974096
Comment on attachment 8412198 [details] [diff] [review]
1001182-refreshAuth.patch

Review of attachment 8412198 [details] [diff] [review]:
-----------------------------------------------------------------

::: services/fxaccounts/FxAccountsManager.jsm
@@ +377,5 @@
>            }
>  
>            // RPs might require an authentication refresh.
>            if (aOptions &&
> +              (typeof(aOptions.refreshAuthentication) != 'undefined')) {

I hate to be that guy, but for gecko these should be double-quotes.  Kill me now.
Attachment #8412198 - Flags: review?(jparsons) → review+
Assignee

Comment 3

5 years ago
Attachment #8412198 - Attachment is obsolete: true
Assignee

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/5e58a8f23067
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.