Closed
Bug 1001182
Opened 10 years ago
Closed 10 years ago
FxAccountsManager.jsm should correctly handle {refreshAuthentication:0} from mozId.request()
Categories
(Firefox OS Graveyard :: FxA, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: spenrose, Assigned: spenrose)
References
Details
Attachments
(1 file, 1 obsolete file)
1.35 KB,
patch
|
Details | Diff | Splinter Review |
I made a silly mistake in the existing code, casting refreshAuthentication to a boolean to see if it exists. Short patch coming for review.
Assignee | ||
Comment 1•10 years ago
|
||
Fun with casting to boolean.
Attachment #8412198 -
Flags: review?(jparsons)
Comment 2•10 years ago
|
||
Comment on attachment 8412198 [details] [diff] [review] 1001182-refreshAuth.patch Review of attachment 8412198 [details] [diff] [review]: ----------------------------------------------------------------- ::: services/fxaccounts/FxAccountsManager.jsm @@ +377,5 @@ > } > > // RPs might require an authentication refresh. > if (aOptions && > + (typeof(aOptions.refreshAuthentication) != 'undefined')) { I hate to be that guy, but for gecko these should be double-quotes. Kill me now.
Attachment #8412198 -
Flags: review?(jparsons) → review+
Assignee | ||
Comment 3•10 years ago
|
||
Attachment #8412198 -
Attachment is obsolete: true
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 4•10 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/5e58a8f23067
Keywords: checkin-needed
Comment 5•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/5e58a8f23067
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•