Closed Bug 1001182 Opened 7 years ago Closed 7 years ago

FxAccountsManager.jsm should correctly handle {refreshAuthentication:0} from mozId.request()

Categories

(Firefox OS Graveyard :: FxA, defect)

All
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: spenrose, Assigned: spenrose)

References

Details

Attachments

(1 file, 1 obsolete file)

I made a silly mistake in the existing code, casting refreshAuthentication to a boolean to see if it exists. Short patch coming for review.
Blocks: 1000323
Attached patch 1001182-refreshAuth.patch (obsolete) — Splinter Review
Fun with casting to boolean.
Attachment #8412198 - Flags: review?(jparsons)
Blocks: 974096
Comment on attachment 8412198 [details] [diff] [review]
1001182-refreshAuth.patch

Review of attachment 8412198 [details] [diff] [review]:
-----------------------------------------------------------------

::: services/fxaccounts/FxAccountsManager.jsm
@@ +377,5 @@
>            }
>  
>            // RPs might require an authentication refresh.
>            if (aOptions &&
> +              (typeof(aOptions.refreshAuthentication) != 'undefined')) {

I hate to be that guy, but for gecko these should be double-quotes.  Kill me now.
Attachment #8412198 - Flags: review?(jparsons) → review+
Attachment #8412198 - Attachment is obsolete: true
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/5e58a8f23067
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.