Closed
Bug 1001233
Opened 10 years ago
Closed 10 years ago
"ASSERTION: writing-mode mismatch" with li::-moz-list-bullet { direction: rtl; }
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: jruderman, Assigned: jfkthame)
References
Details
(Keywords: assertion, regression, testcase, Whiteboard: [qa-] )
Attachments
(4 files)
139 bytes,
text/html
|
Details | |
12.19 KB,
text/plain
|
Details | |
3.77 KB,
patch
|
jfkthame
:
review-
|
Details | Diff | Splinter Review |
3.91 KB,
patch
|
smontagu
:
review+
lsblakk
:
approval-mozilla-aurora+
lsblakk
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
(Another assertion like in bug 986899) ###!!! ASSERTION: writing-mode mismatch: 'aWritingMode == mWritingMode', file WritingModes.h, line 732
Reporter | ||
Comment 1•10 years ago
|
||
Comment 2•10 years ago
|
||
This patch prevents the assertions. I'm not quite sure if the rendering is correct, but I don't think this is a case we really have to care about in the real world.
Assignee: nobody → smontagu
Attachment #8420652 -
Flags: review?(jfkthame)
Assignee | ||
Comment 3•10 years ago
|
||
Comment on attachment 8420652 [details] [diff] [review] Patch Review of attachment 8420652 [details] [diff] [review]: ----------------------------------------------------------------- ::: layout/generic/nsBlockFrame.cpp @@ +6879,5 @@ > + LogicalRect logicalFAS(blockWM, floatAvailSpace, containerWidth); > + nscoord iStart = logicalFAS.IStart(blockWM) - > + rs.ComputedLogicalBorderPadding().IStart(blockWM) - > + reflowState.ComputedLogicalMargin().IEnd(bulletWM) - > + aMetrics.ISize(); No, this can't be right - it's arithmetically combining logical coordinates in (potentially) different writing modes, which is meaningless. The error becomes visible, for example, if you add some content to the testcase and include margin-right:1em; to the li::-moz-list-bullet style: the margin fails to show up to the right of the bullet.
Attachment #8420652 -
Flags: review?(jfkthame) → review-
Assignee | ||
Comment 4•10 years ago
|
||
Here's what I think we actually need to do in this case.
Attachment #8420916 -
Flags: review?(smontagu)
Updated•10 years ago
|
Attachment #8420916 -
Flags: review?(smontagu) → review+
Assignee | ||
Comment 5•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/1e15bbf34b27
Assignee: smontagu → jfkthame
Target Milestone: --- → mozilla32
Assignee | ||
Comment 6•10 years ago
|
||
The faulty code here was part of patch 1 in bug 789096, and as such it's now on aurora and beta branches as well. So we should consider uplifting the fix here once it's safely in Nightly.
status-firefox29:
--- → unaffected
status-firefox30:
--- → affected
status-firefox31:
--- → affected
status-firefox32:
--- → affected
Comment 7•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1e15bbf34b27
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Assignee | ||
Comment 8•10 years ago
|
||
Comment on attachment 8420916 [details] [diff] [review] convert bullet frame's margin to the block frame's writing mode when positioning bullet. [Approval Request Comment] Bug caused by (feature/regressing bug #): 789096 (patch 1) User impact if declined: Possibility of misplaced or missing bullets in (unusual) bidi cases. Testing completed (on m-c, etc.): Landed on m-c; includes testcase. Risk to taking this patch (and alternatives if risky): Minimal risk: there's no security issue involved here, AFAICS, only the possibility of the bullet being placed wrongly. Patch is extremely localized and does not affect anything else apart from positioning of the bullet frame. String or IDL/UUID changes made by this patch: none
Attachment #8420916 -
Flags: approval-mozilla-beta?
Attachment #8420916 -
Flags: approval-mozilla-aurora?
Updated•10 years ago
|
Attachment #8420916 -
Flags: approval-mozilla-beta?
Attachment #8420916 -
Flags: approval-mozilla-beta+
Attachment #8420916 -
Flags: approval-mozilla-aurora?
Attachment #8420916 -
Flags: approval-mozilla-aurora+
Comment 9•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/ceff945c64ce https://hg.mozilla.org/releases/mozilla-beta/rev/542398357372
Updated•10 years ago
|
status-b2g-v1.4:
--- → fixed
status-b2g-v2.0:
--- → fixed
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•