Closed
Bug 1001237
Opened 12 years ago
Closed 12 years ago
"ASSERTION: InitialOverflowProperty must be set first"
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: jruderman, Assigned: kip)
References
Details
(Keywords: assertion, regression, testcase)
Attachments
(4 files, 1 obsolete file)
|
256 bytes,
text/html
|
Details | |
|
5.95 KB,
text/plain
|
Details | |
|
1.00 KB,
patch
|
dbaron
:
review+
|
Details | Diff | Splinter Review |
|
1.78 KB,
patch
|
dbaron
:
review+
|
Details | Diff | Splinter Review |
###!!! ASSERTION: InitialOverflowProperty must be set first.: 'hasInitialOverflowPropertyApplied', file RestyleTracker.h
This assertion was added in bug 984226.
|
Reporter | |
Comment 1•12 years ago
|
||
Could you have a look at what's going on here?
Flags: needinfo?(kgilbert)
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → kgilbert
Flags: needinfo?(kgilbert)
|
|
Assignee | |
Comment 3•12 years ago
|
||
Have reproduced and am investigating
|
|
Assignee | |
Comment 4•12 years ago
|
||
Proposed fix -- nsStyleDisplay::CalcDifference will no longer return nsChangeHint_UpdatePostTransformOverflow when a transform is added.
Attachment #8413889 -
Flags: review?(dbaron)
|
|
Assignee | |
Comment 5•12 years ago
|
||
Attachment #8413909 -
Flags: review?(dbaron)
|
|
Assignee | |
Comment 6•12 years ago
|
||
Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=11ce084c8ee6
Comment on attachment 8413889 [details] [diff] [review]
V1 fix for Bug 1001237
This will leave us with nothing updating the overflow area in the other case. I suspect it would work to use the other overflow-updating hint instead.
This also has a null-dereference, since the condition you reused only makes sense when the previous conditon in the if is checked first.
Attachment #8413889 -
Flags: review?(dbaron) → review-
Comment on attachment 8413909 [details] [diff] [review]
V1 Crashtest for Bug 1001237,r=dbaron
r=dbaron if this asserts without the patch and doesn't with it
Attachment #8413909 -
Flags: review?(dbaron) → review+
|
|
Assignee | |
Comment 9•12 years ago
|
||
Updated to address review in Comment 7
Attachment #8413889 -
Attachment is obsolete: true
Attachment #8414014 -
Flags: review?(dbaron)
|
|
Assignee | |
Comment 10•12 years ago
|
||
Comment on attachment 8414014 [details] [diff] [review]
V2 fix for Bug 1001237,r=dbaron
Updated patch pushed to try:
https://tbpl.mozilla.org/?tree=Try&rev=3ff78be63053
Attachment #8414014 -
Flags: review?(dbaron) → review+
|
|
Assignee | |
Updated•12 years ago
|
Attachment #8414014 -
Attachment description: V2 fix for Bug 1001237 → V2 fix for Bug 1001237,r=dbaron
|
|
Assignee | |
Updated•12 years ago
|
Attachment #8413909 -
Attachment description: V1 Crashtest for Bug 1001237 → V1 Crashtest for Bug 1001237,r=dbaron
|
|
Assignee | |
Updated•12 years ago
|
Keywords: checkin-needed
|
||
Comment 12•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/94b14c87a75e
https://hg.mozilla.org/integration/mozilla-inbound/rev/d911a4befffe
Flags: in-testsuite+
Keywords: checkin-needed
|
|
||
Comment 13•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/94b14c87a75e
https://hg.mozilla.org/mozilla-central/rev/d911a4befffe
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in
before you can comment on or make changes to this bug.
Description
•