1001241 - Make linter error filenames shorter

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Jonathan Griffin (:jgriffin)]

Ryan noted that errors reported by the linter are unnecessarily long, e.g.

TEST-UNEXPECTED-FAIL | /builds/slave/test/gaia/apps/camera/js/views/viewfinder.js | Line 276, E:0240: @param descriptions must end with valid punctuation such as a period.

We could improve this by only including the portion of the filename underneath gaia.

Comment 1

[Jonathan Griffin (:jgriffin)]

Attachment: Make linter error filenames shorter,

This produces errors like:

TEST-UNEXPECTED-FAIL | apps/camera/js/views/viewfinder.js | Line 276, E:0240: @param descriptions must end with valid punctuation such as a period.

Comment 2

[Andrew Halberstadt [:ahal]]

Comment on attachment 8412320 [details] [diff] [review]
Make linter error filenames shorter,

Review of attachment 8412320 [details] [diff] [review]:
-----------------------------------------------------------------

Lgtm, assuming my below assumption is correct

::: scripts/gaia_linter.py
@@ +30,4 @@
>      GENERAL_ERRORS = (re.compile('make(.*?)\*\*\*(.*?)Error'),)
>  
>      def __init__(self, **kwargs):
> +        self.base_dir = kwargs.pop('base_dir')

Just a warning that this will remove 'base_dir' from the super class' kwargs. I don't have enough context, so I'll assume the super class isn't using it :)

Comment 3

[Jonathan Griffin (:jgriffin)]

Yep, the super class doesn't use base_dir.

Comment 4

[Jonathan Griffin (:jgriffin)]

https://hg.mozilla.org/build/mozharness/rev/69de7997d9b5

Comment 5

[Jonathan Griffin (:jgriffin)]

This is running fine on cedar; will let it ride the next push to production.

Comment 6

[Jordan Lund (:jlund)]

mozharness patch is in production: http://hg.mozilla.org/build/mozharness/rev/2947d4bd1276 :)