1001361 - HTTP Cache directory created inside Cache directory (nesting)

Status: RESOLVED FIXED

(Core :: Networking: Cache, defect)

Description

[Honza Bambas (:mayhemer)]

Attachment: v1 (as in the patch for bug 916052, r=michal)

Regression from bug 964898, landed on 30.

Under some (fortunately rare) circumstances it may happen we append "Cache" leaf name to the HTTP cache directory name more then once, see [1], the mObserver->DiskCacheParentDirectory() is not cloned.  I have found Cache/Cache in my local (regular) profile dir!

Found during work on bug 916052 (the patch for that bug has the fix, but I plan to land it on 32, however this needs to go in now).


[1] http://hg.mozilla.org/mozilla-central/diff/955e0211df10/netwerk/cache/nsCacheService.cpp

Comment 1

[Honza Bambas (:mayhemer)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/3d0c2e8d8f4e

Comment 2

[Honza Bambas (:mayhemer)]

Comment on attachment 8412501 [details] [diff] [review]
v1 (as in the patch for bug 916052, r=michal)

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 964898
User impact if declined: Lose access to HTTP cache data while these data are left on disk, creation of a nested Cache directory that for the time of the session eats disk space and after the session ends it's left forever
Testing completed (on m-c, etc.): just landed
Risk to taking this patch (and alternatives if risky): low, the code path creating this bug is executed rarely and is very simple
String or IDL/UUID changes made by this patch: none

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3d0c2e8d8f4e

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/8f8dabb57393