1001392 - Refactor components concatenation style in mozmill-tests

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Cosmin Malutan, [:cosmin-malutan]]

As mentioned in bug 989922 comment 40, when splitting a component call in multiple lines the dot should go to the new line:
>  Cc["@mozilla.org/moz/jssubscript-loader;1"].
>  getService(Ci.mozIJSSubScriptLoader).
>  loadSubScript("chrome://browser/content/sanitize.js", tempScope); 
Should be:
>  Cc["@mozilla.org/moz/jssubscript-loader;1"]
>  .getService(Ci.mozIJSSubScriptLoader)
>  .loadSubScript("chrome://browser/content/sanitize.js", tempScope);
https://developer.mozilla.org/en-US/docs/Mozilla/QA/Mozmill_tests/Mozmill_Style_Guide#Components

Comment 1

[Anna]

Attachment: RefactorStyle.patch

Is this OK?

Comment 2

[Andreea Matei [:AndreeaMatei]]

Comment on attachment 8443863 [details] [diff] [review]
RefactorStyle.patch

Review of attachment 8443863 [details] [diff] [review]:
-----------------------------------------------------------------

Ran some testruns and checked if there are any instances left, it appears not :)

Thanks Anna, hope you enjoyed working with Mozmill and let me know if you want me to suggest another bug to continue on!

Landed: 
http://hg.mozilla.org/qa/mozmill-tests/rev/3b7023a495af (default)

Comment 3

[Anna]

Please do point me in the direction of the next bug :)

Comment 4

[Andreea Matei [:AndreeaMatei]]

What about bug 1000832? It's already in progress and would be great to have it finished. Please check the comments and let me know if you have questions in there or on #automation on IRC.