1001529 - Telemetry experiments: "Experiments" container not initially visible when there's a disabled experiment

Status: RESOLVED DUPLICATE of bug 1001787

(Toolkit :: Add-ons Manager, defect)

Description

[Kamil Jozwiak [:kjozwiak]]

When removing the experiment from the "Experiments" add-on manager using the visible "Remove" button, the experiment will be removed from the container. Refreshing the screen at that point will completely remove the "Experiments" add-ons container. The "Experiments" category will appear again once you hit the refresh button the second time around.

However, if you right click on the experiment and select "Remove", refreshing the first time around will correctly disable the experiment that was removed and the "Experiments" container will still be visible.

Video of issue:
- http://youtu.be/jUxEGVY7YMw

Steps to reproduce the issue:

1) Install the latest Nightly Firefox
2) Once installed, setup a local staging server (see Bug # 973998 on instructions)
3) Once the experiment is enabled and the "Experiments" category is visible, select "Remove" (experiment will disappear)
4) Hit the refresh button and you'll notice that the entire "Experiments" category is removed
5) Hit refresh the second time and you'll notice that the "Experiments" category will re-appear and the experiment will be disabled

Current Behaviour:

- Removing the experiment via the visible "Remove" button should have the same behaviour when removing the experiment via the right click method.

Expected Behaviour:

- The "Experiments" category shouldn't be removed and should be correctly "refreshed" the first time around rather than pressing refresh two different times. Behaviour should be consistent when using any of the three "remove" methods.

Comment 1

[Benjamin Smedberg]

I think this is an expected manifestation of bug 992258 not being landed yet.

Comment 2

[Kamil Jozwiak [:kjozwiak]]

While going through Bug # 1001787, I noticed that when you disable an experiment and re-load Firefox, the experiment container in the add-on manager completely disappears. Reloading the add-on manager or refreshing it won't do anything. However if you go into "about:support" and then re-load the add-on manager, the container will appear and will correctly list the disabled experiment.

Probably a cause of Bug # 992258 as Benjamin mentioned in comment #1

Comment 3

[Georg Fritzsche [:gfritzsche]]

Fixed by bug 1001787.

Comment 4

[Kamil Jozwiak [:kjozwiak]]

Georg,

It looks like this hasn't been fixed in Bug # 1001787 as I can still reproduce this problem. Once you disable/uninstall an experiment and close/re-open firefox, the "Experiments' container will won't be visible unless you visit about:support. At that point, you can refresh about:addons and the "Experiments" container will re-appear.

We should be displaying the "Experiments" container under about:addons the first time around if:
- There's an experiment currently installed
- There's previously installed experiments that have been disabled/removed

Originally, you could press refresh a few times and the "Experiments" will appear without visiting about:support.

Comment 5

[Kamil Jozwiak [:kjozwiak]]

Quick Clarification:

Originally, you could just refresh about:addons and the "Experiments" container will appear. Now, you have to visit about:support before you can refresh about:addons to get the "Experiments" container. Without visiting about:support, refreshing about:addons won't show the "Experiments" container.

Comment 6

[Georg Fritzsche [:gfritzsche]]

(In reply to Kamil Jozwiak [:kjozwiak] from comment #5)
> Originally, you could just refresh about:addons and the "Experiments"
> container will appear. Now, you have to visit about:support before you can
> refresh about:addons to get the "Experiments" container. Without visiting
> about:support, refreshing about:addons won't show the "Experiments"
> container.

In bug 993084 we actually started to delay initializing the experiments manager for performance reasons by 30 seconds after session init - i think this is what you're actually seeing and visiting about:support bypasses that.

Please try again and wait a little more than 30 seconds after second start to re-check this.

Comment 7

[Benjamin Smedberg]

How do we make it so that opening the addon manager will load experiments?

Comment 8

[Kamil Jozwiak [:kjozwiak]]

Waiting the 30 seconds definitely worked, however I did notice the "Experiments" container quickly "flash" as it appeared/disappeared if about:addons was opened before the 30 seconds delay. I think we should clean that up so users don't see things appearing and disappearing quickly.

Comment 9

[Georg Fritzsche [:gfritzsche]]

(In reply to Kamil Jozwiak [:kjozwiak] from comment #8)
> Waiting the 30 seconds definitely worked, however I did notice the
> "Experiments" container quickly "flash" as it appeared/disappeared if
> about:addons was opened before the 30 seconds delay. I think we should clean
> that up so users don't see things appearing and disappearing quickly.

Sure, although that doesn't seem quite as pressing. Can you file a new bug on this?

Comment 10

[Georg Fritzsche [:gfritzsche]]

(In reply to Benjamin Smedberg  [:bsmedberg] from comment #7)
> How do we make it so that opening the addon manager will load experiments?

Filed bug 1005270.