Closed
Bug 1001550
Opened 10 years ago
Closed 10 years ago
"WARNING: Found a non-root APZ with no handoff parent" when changing wallpapers
Categories
(Core :: Panning and Zooming, defect)
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: botond, Assigned: kats)
References
Details
Attachments
(1 file)
1.81 KB,
patch
|
tnikkel
:
review+
|
Details | Diff | Splinter Review |
The STR in bug 1000634 shows the following APZ warnings being given: [Parent 861] WARNING: Found a non-root APZ with no handoff parent: file ../../../gfx/layers/apz/src/APZCTreeManager.cpp, line 909 [Parent 861] WARNING: Found a non-root APZ with no handoff parent: file ../../../gfx/layers/apz/src/APZCTreeManager.cpp, line 909 [Parent 861] WARNING: Found a non-root APZ with no handoff parent: file ../../../gfx/layers/apz/src/APZCTreeManager.cpp, line 909 [Parent 861] WARNING: Found a non-root APZ with no handoff parent: file ../../../gfx/layers/apz/src/APZCTreeManager.cpp, line 909 [Parent 861] WARNING: Found a non-root APZ with no handoff parent: file ../../../gfx/layers/apz/src/APZCTreeManager.cpp, line 909 These warnings indicate a bug in the layout code that computes scroll handoff parents (introduced in bug 982888). We should investigate them.
Comment 1•10 years ago
|
||
These warnings are very common on b2g
Assignee | ||
Comment 3•10 years ago
|
||
Needs more testing.
Assignee | ||
Comment 4•10 years ago
|
||
Comment on attachment 8414778 [details] [diff] [review] Patch Review of attachment 8414778 [details] [diff] [review]: ----------------------------------------------------------------- Did some more testing. Verified this doesn't regress bug 982888.
Attachment #8414778 -
Flags: review?(tnikkel)
Comment 5•10 years ago
|
||
Comment on attachment 8414778 [details] [diff] [review] Patch Do this only when we are ignoringViewPortScrolling?
Attachment #8414778 -
Flags: review?(tnikkel) → review+
Reporter | ||
Comment 6•10 years ago
|
||
Comment on attachment 8414778 [details] [diff] [review] Patch Review of attachment 8414778 [details] [diff] [review]: ----------------------------------------------------------------- ::: layout/base/nsLayoutUtils.cpp @@ +2685,5 @@ > + ViewID id = FrameMetrics::NULL_SCROLL_ID; > + if (presContext->IsRootContentDocument()) { > + if (nsIFrame* rootScrollFrame = presShell->GetRootScrollFrame()) { > + if (nsIContent* content = rootScrollFrame->GetContent()) { > + id = nsLayoutUtils::FindOrCreateIDFor(content); Does this make the call to FindOrCreateIDFor() in nsDisplayList::PaintForFrame() redundant?
Comment 7•10 years ago
|
||
It'll just find the same id. So not a big deal I think.
Assignee | ||
Comment 8•10 years ago
|
||
(In reply to Timothy Nikkel (:tn) from comment #5) > Do this only when we are ignoringViewPortScrolling? Fixed and landed: https://hg.mozilla.org/integration/mozilla-inbound/rev/5a7de0eb94fe
Comment 9•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/5a7de0eb94fe
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in
before you can comment on or make changes to this bug.
Description
•